Re: VFlip problem in gspca_pac7311

[Jean-Francois Moine <moinejf@free.fr>]

On Mon, 23 Nov 2009 14:10:42 -0300
Gustavo Chaín Dumit <g@0xff.cl> wrote:
> I'm testing a Pixart Imaging device (0x93a:0x2622)
> Everything works fine, but vertical orientation. Image looks rotated.
> So I wrote a little hack to prevent it.
> 
> diff --git a/drivers/media/video/gspca/pac7311.c
> b/drivers/media/video/gspca/pac 7311.c
> index 0527144..f7904ec 100644
> --- a/drivers/media/video/gspca/pac7311.c
> +++ b/drivers/media/video/gspca/pac7311.c
> @@ -690,27 +690,28 @@ static int sd_start(struct gspca_dev *gspca_dev)
>         }
>         setgain(gspca_dev);
>         setexposure(gspca_dev);
> -       sethvflip(gspca_dev);
> +       if (gspca_dev->dev->descriptor.idProduct != 0x2622)
> +               sethvflip(gspca_dev);
> 
> Any one has the same problem ?

Yes, other people have the same problem with this webcam. I was
changing the driver when I found a problem.

The vertical and horizontal flips are set in the register 0x21 of the
page 3. The function sethvflip() sets 0x08 for Hflip and 0x04 for
Vflip. By default, this register is set to 0x08 and when sethvflip() is
called, it sets back the value to 0 (no H nor V flip).

As your patch prevents sethvflip to be called, the value 0x08 should be
Vflip and not Hflip. May you confirm that changing Vflip by program
(v4l2ucp, v4l2-ctl...)  does mirroring?

Regards.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/