From: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
To: linux-media@vger.kernel.org
Cc: Hans Verkuil <hverkuil@xs4all.nl>
Subject: V4L1 compatibility broken for VIDIOCGTUNER with radio
Date: Thu, 3 Dec 2009 16:56:20 -0200 [thread overview]
Message-ID: <200912031656.20893.herton@mandriva.com.br> (raw)
Hi,
After commit 9bedc7f ("V4L/DVB (12429): v4l2-ioctl: fix G_STD and G_PARM
default handlers"), radio software using V4L1 stopped to work on a saa7134
card, a git bisect pointed to this commit introducing the regression. All
VIDIOCGTUNER calls on a v4l1 application are returning -EINVAL after this
commit.
Investigating the issue, it turns out that v4l1_compat_get_tuner calls
VIDIOC_G_STD ioctl, but as it is a radio device (saa7134-radio) it now is
returning -EINVAL to user space applications which are being confused about
this.
May be VIDIOC_G_STD change in the commit above should be reverted, or
v4l1_compat_get_tuner changed to not return error with G_STD, or not call
G_STD ioctl for a radio device?
--
[]'s
Herton
next reply other threads:[~2009-12-03 18:56 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-03 18:56 Herton Ronaldo Krzesinski [this message]
2009-12-03 21:54 ` V4L1 compatibility broken for VIDIOCGTUNER with radio hermann pitton
2009-12-03 23:04 ` Herton Ronaldo Krzesinski
2009-12-04 1:10 ` hermann pitton
2009-12-04 8:29 ` Michael Krufky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912031656.20893.herton@mandriva.com.br \
--to=herton@mandriva.com.br \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox