From: Jean-Francois Moine <moinejf@free.fr>
To: "Németh Márton" <nm127@freemail.hu>
Cc: V4L Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] gspca m5602: eliminate sparse warnings
Date: Sat, 12 Dec 2009 11:21:45 +0100 [thread overview]
Message-ID: <20091212112145.228bb01c@tele> (raw)
In-Reply-To: <4B22BAB0.5070604@freemail.hu>
On Fri, 11 Dec 2009 22:33:36 +0100
Németh Márton <nm127@freemail.hu> wrote:
> From: Márton Németh <nm127@freemail.hu>
>
> Eliminate the following sparse warnings (see "make C=1"):
> * v4l/m5602_s5k4aa.c:530:23: warning: dubious: x | !y
> * v4l/m5602_s5k4aa.c:575:23: warning: dubious: x | !y
>
> Signed-off-by: Márton Németh <nm127@freemail.hu>
> ---
> ../../m5602_s5k4aa_dubious.patch
> diff -r f5662ce08663
> linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c ---
> a/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c Fri Dec
> 11 09:53:41 2009 +0100 +++
> b/linux/drivers/media/video/gspca/m5602/m5602_s5k4aa.c Fri Dec
> 11 22:25:50 2009 +0100 @@ -527,7 +527,7 @@ err =
> m5602_read_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1); if (err < 0)
> return err;
> - data = (data & 0xfe) | !val;
> + data = (data & 0xfe) | (val ? 0 : 1);
> err = m5602_write_sensor(sd, S5K4AA_ROWSTART_LO, &data, 1);
> return err;
> }
> @@ -572,7 +572,7 @@
> err = m5602_read_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
> if (err < 0)
> return err;
> - data = (data & 0xfe) | !val;
> + data = (data & 0xfe) | (val ? 0 : 1);
> err = m5602_write_sensor(sd, S5K4AA_COLSTART_LO, &data, 1);
> return err;
> }
Thanks, but I fixed it in an other way.
Regards.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2009-12-12 10:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-11 21:33 [PATCH] gspca m5602: eliminate sparse warnings Németh Márton
2009-12-12 10:21 ` Jean-Francois Moine [this message]
2009-12-12 11:15 ` Németh Márton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091212112145.228bb01c@tele \
--to=moinejf@free.fr \
--cc=linux-media@vger.kernel.org \
--cc=nm127@freemail.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox