From: Jean-Francois Moine <moinejf@free.fr>
To: Luis Maia <lmaia@royalhat.org>
Cc: linux-media@vger.kernel.org
Subject: Re: PATCH- gspca: added chipset revision sensor
Date: Tue, 15 Dec 2009 08:54:45 +0100 [thread overview]
Message-ID: <20091215085445.093ebfd8@tele> (raw)
In-Reply-To: <4B27063C.6020200@royalhat.org>
On Tue, 15 Dec 2009 03:45:00 +0000
Luis Maia <lmaia@royalhat.org> wrote:
> Added extra chipset revision (sensor) to fix camera zc0301 with ID:
> 0ac8:301b .
> Since i own one of this cameras fixed and tested it.
> -------------
>
> diff -uNr linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c
> linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
> --- linux-2.6.32.1/drivers/media/video/gspca/zc3xx.c 2009-12-14
> 17:47:25.000000000 +0000
> +++ linux-2.6.32.1-patch/drivers/media/video/gspca/zc3xx.c
> 2009-12-15 02:42:13.000000000 +0000
> @@ -6868,6 +6868,7 @@
> {0x8001, 0x13},
> {0x8000, 0x14}, /* CS2102K */
> {0x8400, 0x15}, /* TAS5130K */
> + {0xe400, 0x15},
> };
>
> static int vga_3wr_probe(struct gspca_dev *gspca_dev)
> @@ -7634,7 +7635,7 @@
> {USB_DEVICE(0x0698, 0x2003)},
> {USB_DEVICE(0x0ac8, 0x0301), .driver_info = SENSOR_PAS106},
> {USB_DEVICE(0x0ac8, 0x0302), .driver_info = SENSOR_PAS106},
> - {USB_DEVICE(0x0ac8, 0x301b)},
> + {USB_DEVICE(0x0ac8, 0x301b), .driver_info = SENSOR_PB0330},
> {USB_DEVICE(0x0ac8, 0x303b)},
> {USB_DEVICE(0x0ac8, 0x305b), .driver_info =
> SENSOR_TAS5130C_VF0250}, {USB_DEVICE(0x0ac8, 0x307b)},
Hello Luis,
I don't understand your patch:
1) you added 0xe400 in the chipset table giving the sensor tas5130c K
2) in the device table you say that the 0ac8:301b sensor is a pb0330
(but this information is not used: the sensor type in .driver_info
may be only pas106 for sif probe or mc501cb/tas5130_vf0250 for no
probe.
What is exactly the sensor of your webcam?
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2009-12-15 7:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-15 3:45 PATCH- gspca: added chipset revision sensor Luis Maia
2009-12-15 7:54 ` Jean-Francois Moine [this message]
2009-12-15 13:25 ` leandro Costantino
2009-12-15 16:47 ` Jean-Francois Moine
2009-12-16 0:34 ` Luis Maia
2009-12-16 0:47 ` leandro Costantino
2009-12-15 16:00 ` Luis Maia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20091215085445.093ebfd8@tele \
--to=moinejf@free.fr \
--cc=linux-media@vger.kernel.org \
--cc=lmaia@royalhat.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox