* [patch] cx25821: fix double unlock in medusa_video_init()
@ 2009-12-28 16:59 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2009-12-28 16:59 UTC (permalink / raw)
To: linux-media, devel; +Cc: Greg Kroah-Hartman
medusa_set_videostandard() takes the lock but it always drops it before
returning.
This was found with a static checker and compile tested only. :/
Signed-off-by: Dan Carpenter <error27@gmail.com>
--- orig/drivers/staging/cx25821/cx25821-medusa-video.c 2009-12-28 09:13:01.000000000 +0200
+++ devel/drivers/staging/cx25821/cx25821-medusa-video.c 2009-12-28 09:13:55.000000000 +0200
@@ -860,10 +860,8 @@ int medusa_video_init(struct cx25821_dev
ret_val = medusa_set_videostandard(dev);
- if (ret_val < 0) {
- mutex_unlock(&dev->lock);
+ if (ret_val < 0)
return -EINVAL;
- }
return 1;
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2009-12-28 17:00 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-28 16:59 [patch] cx25821: fix double unlock in medusa_video_init() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox