From: Matthias Schwarzott <zzam@gentoo.org>
To: linux-media@vger.kernel.org
Cc: Dan Carpenter <error27@gmail.com>,
Matthias Schwarzott <zzam@gentoo.de>,
Mauro Carvalho Chehab <mchehab@infradead.org>
Subject: Re: [patch] fix weird array index in zl10036.c
Date: Tue, 29 Dec 2009 11:08:16 +0100 [thread overview]
Message-ID: <200912291108.16880.zzam@gentoo.org> (raw)
In-Reply-To: <20091228174849.GG17645@bicker>
On Montag, 28. Dezember 2009, Dan Carpenter wrote:
> I was initially concerned about the weird array index (the 2 bumps
> into the next row of the array). Matthias Schwarzott look at the
> datasheet and it turns out it should be zl10036_init_tab[1][0] |= 0x01;
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Signed-off-by: Matthias Schwarzott <zzam@gentoo.org>
It may be better to add "linux/" path component to make it apply easier.
Matthias
>
> --- orig/drivers/media/dvb/frontends/zl10036.c 2009-12-28
> 19:04:51.000000000 +0200 +++
> devel/drivers/media/dvb/frontends/zl10036.c 2009-12-28 19:07:18.000000000
> +0200 @@ -411,7 +411,7 @@ static int zl10036_init_regs(struct zl10
> state->bf = 0xff;
>
> if (!state->config->rf_loop_enable)
> - zl10036_init_tab[1][2] |= 0x01;
> + zl10036_init_tab[1][0] |= 0x01;
>
> deb_info("%s\n", __func__);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2009-12-29 10:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-12-27 13:15 weird array index in zl10036.c Dan Carpenter
2009-12-27 17:02 ` Matthias Schwarzott
2009-12-28 17:48 ` [patch] fix " Dan Carpenter
2009-12-29 10:08 ` Matthias Schwarzott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200912291108.16880.zzam@gentoo.org \
--to=zzam@gentoo.org \
--cc=error27@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=zzam@gentoo.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox