From: Jean Delvare <khali@linux-fr.org>
To: LMML <linux-media@vger.kernel.org>
Cc: Daro <ghost-rider@aster.pl>, Roman Kellner <muzungu@gmx.net>
Subject: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants
Date: Wed, 27 Jan 2010 12:02:11 +0100 [thread overview]
Message-ID: <20100127120211.2d022375@hyperion.delvare> (raw)
From: Jean Delvare <khali@linux-fr.org>
Subject: saa7134: Fix IR support of some ASUS TV-FM 7135 variants
Some variants of the ASUS TV-FM 7135 are handled as the ASUSTeK P7131
Analog (card=146). However, by the time we find out, some
card-specific initialization is missed. In particular, the fact that
the IR is GPIO-based. Set it when we change the card type.
We also have to move the initialization of IR until after the card
number has been changed. I hope that this won't cause any problem.
Signed-off-by: Jean Delvare <khali@linux-fr.org>
Cc: Daro <ghost-rider@aster.pl>
Cc: Roman Kellner <muzungu@gmx.net>
---
This needs testing, both from ASUS TV-FM 7135 users, and from other
users of the saa7134 driver. I don't have any supported device so I
couldn't test this change.
linux/drivers/media/video/saa7134/saa7134-cards.c | 1 +
linux/drivers/media/video/saa7134/saa7134-core.c | 2 +-
linux/drivers/media/video/saa7134/saa7134-input.c | 2 +-
linux/drivers/media/video/saa7134/saa7134.h | 2 +-
4 files changed, 4 insertions(+), 3 deletions(-)
--- v4l-dvb.orig/linux/drivers/media/video/saa7134/saa7134-cards.c 2010-01-25 21:25:58.000000000 +0100
+++ v4l-dvb/linux/drivers/media/video/saa7134/saa7134-cards.c 2010-01-27 10:22:35.000000000 +0100
@@ -7299,6 +7299,7 @@ int saa7134_board_init2(struct saa7134_d
printk(KERN_INFO "%s: P7131 analog only, using "
"entry of %s\n",
dev->name, saa7134_boards[dev->board].name);
+ dev->has_remote = SAA7134_REMOTE_GPIO;
}
break;
case SAA7134_BOARD_HAUPPAUGE_HVR1150:
--- v4l-dvb.orig/linux/drivers/media/video/saa7134/saa7134-core.c 2010-01-25 21:25:50.000000000 +0100
+++ v4l-dvb/linux/drivers/media/video/saa7134/saa7134-core.c 2010-01-27 10:39:55.000000000 +0100
@@ -735,7 +735,6 @@ static int saa7134_hwinit1(struct saa713
saa7134_vbi_init1(dev);
if (card_has_mpeg(dev))
saa7134_ts_init1(dev);
- saa7134_input_init1(dev);
saa7134_hw_enable1(dev);
@@ -781,6 +780,7 @@ static int saa7134_hwinit2(struct saa713
dprintk("hwinit2\n");
+ saa7134_input_init2(dev);
saa7134_video_init2(dev);
saa7134_tvaudio_init2(dev);
--- v4l-dvb.orig/linux/drivers/media/video/saa7134/saa7134-input.c 2010-01-25 21:25:50.000000000 +0100
+++ v4l-dvb/linux/drivers/media/video/saa7134/saa7134-input.c 2010-01-27 10:33:23.000000000 +0100
@@ -506,7 +506,7 @@ void saa7134_ir_stop(struct saa7134_dev
del_timer_sync(&dev->remote->timer);
}
-int saa7134_input_init1(struct saa7134_dev *dev)
+int saa7134_input_init2(struct saa7134_dev *dev)
{
struct card_ir *ir;
struct input_dev *input_dev;
--- v4l-dvb.orig/linux/drivers/media/video/saa7134/saa7134.h 2010-01-25 21:25:50.000000000 +0100
+++ v4l-dvb/linux/drivers/media/video/saa7134/saa7134.h 2010-01-27 10:34:57.000000000 +0100
@@ -812,7 +812,7 @@ void saa7134_irq_oss_done(struct saa7134
/* ----------------------------------------------------------- */
/* saa7134-input.c */
-int saa7134_input_init1(struct saa7134_dev *dev);
+int saa7134_input_init2(struct saa7134_dev *dev);
void saa7134_input_fini(struct saa7134_dev *dev);
void saa7134_input_irq(struct saa7134_dev *dev);
#if LINUX_VERSION_CODE < KERNEL_VERSION(2, 6, 30)
--
Jean Delvare
next reply other threads:[~2010-01-27 11:02 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 11:02 Jean Delvare [this message]
2010-01-29 15:40 ` [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants Mauro Carvalho Chehab
2010-01-30 0:47 ` hermann pitton
2010-01-30 10:56 ` Jean Delvare
2010-02-01 1:16 ` hermann pitton
2010-02-01 9:56 ` Jean Delvare
2010-02-02 1:47 ` hermann pitton
2010-02-02 7:54 ` Jean Delvare
2010-02-02 11:50 ` Mauro Carvalho Chehab
2010-02-10 18:09 ` Jean Delvare
2010-02-10 18:40 ` Mauro Carvalho Chehab
2010-02-10 19:36 ` Jean Delvare
2010-02-11 0:58 ` hermann pitton
2010-02-15 5:31 ` hermann pitton
2010-02-20 3:07 ` hermann pitton
2010-02-25 13:12 ` Jean Delvare
2010-02-25 21:50 ` hermann pitton
2010-02-02 23:32 ` hermann pitton
2010-02-10 16:38 ` Daro
2010-02-10 17:00 ` Jean Delvare
2010-02-02 19:09 ` Mauro Carvalho Chehab
2010-02-10 17:01 ` Jean Delvare
[not found] <E1Nl2po-000877-Di@services.gcu-squad.org>
2010-03-12 9:38 ` Jean Delvare
2010-03-14 2:38 ` Daro
2010-03-14 5:08 ` hermann pitton
2010-03-14 8:26 ` Jean Delvare
2010-03-14 19:34 ` Daro
2010-03-14 20:48 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100127120211.2d022375@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=ghost-rider@aster.pl \
--cc=linux-media@vger.kernel.org \
--cc=muzungu@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox