From: Jean Delvare <khali@linux-fr.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: hermann pitton <hermann-pitton@arcor.de>,
LMML <linux-media@vger.kernel.org>, Daro <ghost-rider@aster.pl>,
Roman Kellner <muzungu@gmx.net>
Subject: Re: [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants
Date: Wed, 10 Feb 2010 20:36:01 +0100 [thread overview]
Message-ID: <20100210203601.31ef3220@hyperion.delvare> (raw)
In-Reply-To: <4B72FD83.1050500@redhat.com>
On Wed, 10 Feb 2010 16:40:03 -0200, Mauro Carvalho Chehab wrote:
> Jean Delvare wrote:
> > Under the assumption that saa7134_hwinit1() only touches GPIOs
> > connected to IR receivers (and it certainly looks like this to me) I
> > fail to see how these pins not being initialized could have any effect
> > on non-IR code.
>
> Now, i suspect that you're messing things again: are you referring to saa7134_hwinit1() or
> to saa7134_input_init1()?
>
> I suspect that you're talking about moving saa7134_input_init1(), since saa7134_hwinit1()
> has the muted and spinlock inits. It also has the setups for video, vbi and mpeg.
> So, moving it require more care.
Err, you're right, I meant saa7134_input_init1() and not
saa7134_hwinit1(), copy-and-paste error. Sorry for adding more
confusion where it really wasn't needed...
--
Jean Delvare
next prev parent reply other threads:[~2010-02-10 19:36 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 11:02 [PATCH] saa7134: Fix IR support of some ASUS TV-FM 7135 variants Jean Delvare
2010-01-29 15:40 ` Mauro Carvalho Chehab
2010-01-30 0:47 ` hermann pitton
2010-01-30 10:56 ` Jean Delvare
2010-02-01 1:16 ` hermann pitton
2010-02-01 9:56 ` Jean Delvare
2010-02-02 1:47 ` hermann pitton
2010-02-02 7:54 ` Jean Delvare
2010-02-02 11:50 ` Mauro Carvalho Chehab
2010-02-10 18:09 ` Jean Delvare
2010-02-10 18:40 ` Mauro Carvalho Chehab
2010-02-10 19:36 ` Jean Delvare [this message]
2010-02-11 0:58 ` hermann pitton
2010-02-15 5:31 ` hermann pitton
2010-02-20 3:07 ` hermann pitton
2010-02-25 13:12 ` Jean Delvare
2010-02-25 21:50 ` hermann pitton
2010-02-02 23:32 ` hermann pitton
2010-02-10 16:38 ` Daro
2010-02-10 17:00 ` Jean Delvare
2010-02-02 19:09 ` Mauro Carvalho Chehab
2010-02-10 17:01 ` Jean Delvare
[not found] <E1Nl2po-000877-Di@services.gcu-squad.org>
2010-03-12 9:38 ` Jean Delvare
2010-03-14 2:38 ` Daro
2010-03-14 5:08 ` hermann pitton
2010-03-14 8:26 ` Jean Delvare
2010-03-14 19:34 ` Daro
2010-03-14 20:48 ` Jean Delvare
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100210203601.31ef3220@hyperion.delvare \
--to=khali@linux-fr.org \
--cc=ghost-rider@aster.pl \
--cc=hermann-pitton@arcor.de \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
--cc=muzungu@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox