public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean-Francois Moine <moinejf@free.fr>
To: "Németh Márton" <nm127@freemail.hu>
Cc: V4L Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 1/2] gspca pac7302: add LED control
Date: Wed, 24 Feb 2010 08:22:38 +0100	[thread overview]
Message-ID: <20100224082238.53c8f6f8@tele> (raw)
In-Reply-To: <4B84CC9E.4030600@freemail.hu>

On Wed, 24 Feb 2010 07:52:14 +0100
Németh Márton <nm127@freemail.hu> wrote:

> On Labtec Webcam 2200 there is a feedback LED which can be controlled
> independent from the streaming. The feedback LED can be used from
> user space application to show for example detected motion or to
> distinguish between the preview and "on-air" state of the video
> stream.
	[snip]
> +#define PAC7302_CID_LED (V4L2_CID_PRIVATE_BASE + 0)
	[snip]

Hello,

Private controls must not be used. LED control should be generic (I
have many requests for that).

In March 2009, I proposed to add a V4L2_CID_LEDS control ("[PATCH] LED
control"), but someone told me to use the sysfs led interface instead.
After looking at this interface, I thought it was too complex for our
purpose and no easy for the users.

Maybe it is time to argue again...

Cheers.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

  reply	other threads:[~2010-02-24  7:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-24  6:52 [PATCH 1/2] gspca pac7302: add LED control Németh Márton
2010-02-24  7:22 ` Jean-Francois Moine [this message]
2010-02-27  0:20   ` [PATCH 1/2] gspca pac7302: allow controlling LED separately Németh Márton
2010-02-27  7:53     ` Hans de Goede
2010-02-27  8:22       ` Németh Márton
2010-02-27  9:04       ` Jean-Francois Moine
2010-02-27 15:35         ` Németh Márton
2010-02-27 19:12           ` Hans de Goede
2010-02-27 20:00             ` Jean-Francois Moine
2010-02-27  8:17     ` Németh Márton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100224082238.53c8f6f8@tele \
    --to=moinejf@free.fr \
    --cc=linux-media@vger.kernel.org \
    --cc=nm127@freemail.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox