From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-gw0-f46.google.com ([74.125.83.46]:49285 "EHLO mail-gw0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031421Ab0B1HFm (ORCPT ); Sun, 28 Feb 2010 02:05:42 -0500 Date: Sat, 27 Feb 2010 23:05:36 -0800 From: Dmitry Torokhov To: =?iso-8859-1?Q?N=E9meth_M=E1rton?= Cc: Matthew Garrett , Mauro Carvalho Chehab , Jiri Kosina , Linux Input , Linux Media Mailing List , Platform Driver x86 Subject: Re: [PATCH] Input: scancode in get/set_keycodes should be unsigned Message-ID: <20100228070536.GC765@core.coreip.homeip.net> References: <20100228061310.GA765@core.coreip.homeip.net> <4B8A10D0.2020802@freemail.hu> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <4B8A10D0.2020802@freemail.hu> Sender: linux-media-owner@vger.kernel.org List-ID: On Sun, Feb 28, 2010 at 07:44:32AM +0100, Németh Márton wrote: > Hi, > Dmitry Torokhov wrote: > > The HID layer has some scan codes of the form 0xffbc0000 for logitech > > devices which do not work if scancode is typed as signed int, so we need > > to switch to unsigned int instead. While at it keycode being signed does > > not make much sense either. > > Are the scan codes and key codes always 4 bytes long? Then the u32 data > type could be used to take 16 bit (or 64 bit) processors also into > consideration. > We do not support 16 bit processors and for 64 bit 'unsigned int' is still 32 bits. -- Dmitry