From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from cavan.codon.org.uk ([93.93.128.6]:39483 "EHLO cavan.codon.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943Ab0CAOwz (ORCPT ); Mon, 1 Mar 2010 09:52:55 -0500 Date: Mon, 1 Mar 2010 14:52:51 +0000 From: Matthew Garrett To: Dmitry Torokhov Cc: Mauro Carvalho Chehab , Jiri Kosina , Linux Input , Linux Media Mailing List , Platform Driver x86 Subject: Re: [PATCH] Input: scancode in get/set_keycodes should be unsigned Message-ID: <20100301145251.GB14808@srcf.ucam.org> References: <20100228061310.GA765@core.coreip.homeip.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100228061310.GA765@core.coreip.homeip.net> Sender: linux-media-owner@vger.kernel.org List-ID: On Sat, Feb 27, 2010 at 10:13:11PM -0800, Dmitry Torokhov wrote: > The HID layer has some scan codes of the form 0xffbc0000 for logitech > devices which do not work if scancode is typed as signed int, so we need > to switch to unsigned int instead. While at it keycode being signed does > not make much sense either. > > Signed-off-by: Dmitry Torokhov > --- Acked-by: Matthew Garrett -- Matthew Garrett | mjg59@srcf.ucam.org