* Re: [git:v4l-dvb/master] af_key: fix netns ops ordering on module load/unload
[not found] <E1NnuyA-0001Am-Cv@www.linuxtv.org>
@ 2010-03-06 22:46 ` Alexey Dobriyan
0 siblings, 0 replies; only message in thread
From: Alexey Dobriyan @ 2010-03-06 22:46 UTC (permalink / raw)
To: linux-media
On Sat, Mar 06, 2010 at 03:27:06PM +0100, Patch from Alexey Dobriyan wrote:
> From: Alexey Dobriyan <adobriyan@gmail.com>
>
> 1. After sock_register() returns, it's possible to create sockets,
> even if module still not initialized fully (blame generic module code
> for that!)
> 2. Consequently, pfkey_create() can be called with pfkey_net_id still not
> initialized which will BUG_ON in net_generic():
> kernel BUG at include/net/netns/generic.h:43!
> 3. During netns shutdown, netns ops should be unregistered after
> key manager unregistered because key manager calls can be triggered
> from xfrm_user module:
>
> general protection fault: 0000 [#1] PREEMPT SMP DEBUG_PAGEALLOC
> pfkey_broadcast+0x111/0x210 [af_key]
> pfkey_send_notify+0x16a/0x300 [af_key]
> km_state_notify+0x41/0x70
> xfrm_flush_sa+0x75/0x90 [xfrm_user]
> 4. Unregister netns ops after socket ops just in case and for symmetry.
>
> Reported by Luca Tettamanti.
>
> Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>
> Tested-by: Luca Tettamanti <kronos.it@gmail.com>
> Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
> Signed-off-by: David S. Miller <davem@davemloft.net>
What this has to do with DVB?
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-03-06 22:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <E1NnuyA-0001Am-Cv@www.linuxtv.org>
2010-03-06 22:46 ` [git:v4l-dvb/master] af_key: fix netns ops ordering on module load/unload Alexey Dobriyan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox