public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Jean Delvare <khali@linux-fr.org>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Dmitri Belimov <dimon@openhardware.ru>,
	hermann pitton <hermann-pitton@arcor.de>,
	Andy Walls <awalls@radix.net>,
	linux-media@vger.kernel.org, "Timothy D. Lenz" <tlenz@vorgon.com>
Subject: Re: [IR RC, REGRESSION] Didn't work IR RC
Date: Tue, 9 Mar 2010 11:57:48 +0100	[thread overview]
Message-ID: <20100309115748.5ec7fd7a@hyperion.delvare> (raw)
In-Reply-To: <4B8CD10D.2010009@infradead.org>

Hi Mauro, Dmitri,

On Tue, 02 Mar 2010 05:49:17 -0300, Mauro Carvalho Chehab wrote:
> Dmitri Belimov wrote:
> > When I add 
> > 
> > diff -r 37ff78330942 linux/drivers/media/video/ir-kbd-i2c.c
> > --- a/linux/drivers/media/video/ir-kbd-i2c.c	Sun Feb 28 16:59:57 2010 -0300
> > +++ b/linux/drivers/media/video/ir-kbd-i2c.c	Tue Mar 02 10:31:31 2010 +0900
> > @@ -465,6 +519,11 @@
> >  		ir_type     = IR_TYPE_OTHER;
> >  		ir_codes    = &ir_codes_avermedia_cardbus_table;
> >  		break;
> > +	case 0x2d:
> > +		/* Handled by saa7134-input */
> > +		name        = "SAA713x remote";
> > +		ir_type     = IR_TYPE_OTHER;
> > +		break;
> >  	}
> >  
> >  #if LINUX_VERSION_CODE >= KERNEL_VERSION(2, 6, 30)
> > 
> > The IR subsystem register event device. But for get key code use ir_pool_key function.
> > 
> > For our IR RC need use our special function. How I can do it?
> 
> Just add your get_key callback to "ir->get_key". If you want to do this from
> saa7134-input, please take a look at the code at em28xx_register_i2c_ir(). 
> It basically fills the platform_data.
> 
> While you're there, I suggest you to change your code to work with the
> full scancode (e. g. address + command), instead of just getting the command.
> Currently, em28xx-input has one I2C IR already changed to this mode (seek
> for full_code for the differences).
> 
> You'll basically need to change the IR tables to contain address+command, and
> inform the used protocol (RC5/NEC) on it. The getkey function will need to
> return the full code as well.

Sorry for the late reply. Is the problem solved by now, or is my help
still needed?

-- 
Jean Delvare

  reply	other threads:[~2010-03-09 10:57 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-01  6:36 [IR RC, REGRESSION] Didn't work IR RC Dmitri Belimov
2010-03-01 11:28 ` Andy Walls
2010-03-01 13:37   ` Mauro Carvalho Chehab
2010-03-02  4:19     ` hermann pitton
2010-03-02  4:43       ` Dmitri Belimov
2010-03-02  7:36         ` Dmitri Belimov
2010-03-02  8:49           ` Mauro Carvalho Chehab
2010-03-09 10:57             ` Jean Delvare [this message]
2010-03-10  4:02               ` Dmitri Belimov
2010-03-10  9:00                 ` Jean Delvare
2010-03-16 11:05   ` Jean Delvare
2010-03-19 13:42     ` [PATCH] FusionHDTV: Use quick reads for I2C IR device probing Jean Delvare
2010-03-29 15:34       ` Jean Delvare

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100309115748.5ec7fd7a@hyperion.delvare \
    --to=khali@linux-fr.org \
    --cc=awalls@radix.net \
    --cc=dimon@openhardware.ru \
    --cc=hermann-pitton@arcor.de \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@infradead.org \
    --cc=tlenz@vorgon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox