* [patch] em28xx: "Empia Em28xx Audio" too long
@ 2010-03-19 11:48 Dan Carpenter
2010-03-23 11:40 ` [patch v2] " Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-03-19 11:48 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Douglas Schilling Landgraf, Robert Krakora, Nicola Soranzo,
Devin Heitmueller, linux-media, linux-kernel, kernel-janitors
card->driver is 15 characters and a NULL. The original code
goes past the end of the array.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c
index bd78338..530df0a 100644
--- a/drivers/media/video/em28xx/em28xx-audio.c
+++ b/drivers/media/video/em28xx/em28xx-audio.c
@@ -491,7 +491,7 @@ static int em28xx_audio_init(struct em28xx *dev)
strcpy(pcm->name, "Empia 28xx Capture");
snd_card_set_dev(card, &dev->udev->dev);
- strcpy(card->driver, "Empia Em28xx Audio");
+ strcpy(card->driver, "Em28xx Audio");
strcpy(card->shortname, "Em28xx Audio");
strcpy(card->longname, "Empia Em28xx Audio");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [patch v2] em28xx: "Empia Em28xx Audio" too long
2010-03-19 11:48 [patch] em28xx: "Empia Em28xx Audio" too long Dan Carpenter
@ 2010-03-23 11:40 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2010-03-23 11:40 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Douglas Schilling Landgraf, Robert Krakora,
Nicola Soranzo, Devin Heitmueller, linux-media, linux-kernel,
kernel-janitors, Takashi Iwai, Andrew Morton
card->driver is 15 characters and a NULL. The original code
goes past the end of the array.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
V2: Takashi Iwai asked me to change the space to a hyphen since this is
used as an identifier in alsa-lib.
diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c
index bd78338..e182abf 100644
--- a/drivers/media/video/em28xx/em28xx-audio.c
+++ b/drivers/media/video/em28xx/em28xx-audio.c
@@ -491,7 +491,7 @@ static int em28xx_audio_init(struct em28xx *dev)
strcpy(pcm->name, "Empia 28xx Capture");
snd_card_set_dev(card, &dev->udev->dev);
- strcpy(card->driver, "Empia Em28xx Audio");
+ strcpy(card->driver, "Em28xx-Audio");
strcpy(card->shortname, "Em28xx Audio");
strcpy(card->longname, "Empia Em28xx Audio");
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-03-23 11:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-03-19 11:48 [patch] em28xx: "Empia Em28xx Audio" too long Dan Carpenter
2010-03-23 11:40 ` [patch v2] " Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox