From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-fx0-f213.google.com ([209.85.220.213]:53146 "EHLO mail-fx0-f213.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751853Ab0CWLHG (ORCPT ); Tue, 23 Mar 2010 07:07:06 -0400 Date: Tue, 23 Mar 2010 14:06:55 +0300 From: Dan Carpenter To: Olimpiu Pascariu , gregkh@suse.de, mchehab@redhat.com, palash.bandyopadhyay@conexant.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 5/5] Staging: cx25821: fix coding style issues in cx25821-medusa-video.c Message-ID: <20100323110655.GW21571@bicker> References: <1269197503.6971.11.camel@tuxtm-linux> <20100322133513.GO21571@bicker> <1269288630.6365.1.camel@tuxtm-linux> <20100323110259.GV21571@bicker> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20100323110259.GV21571@bicker> Sender: linux-media-owner@vger.kernel.org List-ID: On Tue, Mar 23, 2010 at 02:03:00PM +0300, Dan Carpenter wrote: > On Mon, Mar 22, 2010 at 10:10:30PM +0200, Olimpiu Pascariu wrote: > > >From 32591165a537a03f472c68289798044d6eeea2e0 Mon Sep 17 00:00:00 2001 > > From: Olimpiu Pascariu > > Date: Mon, 22 Mar 2010 22:07:20 +0200 > > Subject: [PATCH 5/5] Staging: cx25821: fix coding style issues in cx25821-medusa-video.c > > This is a patch to cx25821-medusa-video.c file that fixes up warnings and errors found by the checkpatch.pl tool > > Signed-off-by: Olimpiu Pascariu > > [snip] > > > + /* > > + * clear VPRES_VERT_EN bit, fixes the chroma run away problem > > + * when the input switching rate < 16 fields > > + */ > ^^^ > Missing a space here. > > Otherwise looks good. > > Acked-by: Dan Carpenter > > regard, > dan carpenter Oh sorry. I thought this was a new patch. This is fine to go in as is by me... Maybe hold off for a couple days and see if anyone else has any comments. regards, dan carpenter