From: Dan Carpenter <error27@gmail.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>,
Douglas Schilling Landgraf <dougsland@redhat.com>,
Robert Krakora <rob.krakora@messagenetsystems.com>,
Nicola Soranzo <nsoranzo@tiscali.it>,
Devin Heitmueller <dheitmueller@kernellabs.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org, Takashi Iwai <tiwai@suse.de>,
Andrew Morton <akpm@linux-foundation.org>
Subject: [patch v2] em28xx: "Empia Em28xx Audio" too long
Date: Tue, 23 Mar 2010 14:40:43 +0300 [thread overview]
Message-ID: <20100323114043.GY21571@bicker> (raw)
In-Reply-To: <20100319114825.GO5331@bicker>
card->driver is 15 characters and a NULL. The original code
goes past the end of the array.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
V2: Takashi Iwai asked me to change the space to a hyphen since this is
used as an identifier in alsa-lib.
diff --git a/drivers/media/video/em28xx/em28xx-audio.c b/drivers/media/video/em28xx/em28xx-audio.c
index bd78338..e182abf 100644
--- a/drivers/media/video/em28xx/em28xx-audio.c
+++ b/drivers/media/video/em28xx/em28xx-audio.c
@@ -491,7 +491,7 @@ static int em28xx_audio_init(struct em28xx *dev)
strcpy(pcm->name, "Empia 28xx Capture");
snd_card_set_dev(card, &dev->udev->dev);
- strcpy(card->driver, "Empia Em28xx Audio");
+ strcpy(card->driver, "Em28xx-Audio");
strcpy(card->shortname, "Em28xx Audio");
strcpy(card->longname, "Empia Em28xx Audio");
prev parent reply other threads:[~2010-03-23 11:40 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-19 11:48 [patch] em28xx: "Empia Em28xx Audio" too long Dan Carpenter
2010-03-23 11:40 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100323114043.GY21571@bicker \
--to=error27@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=dheitmueller@kernellabs.com \
--cc=dougsland@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=nsoranzo@tiscali.it \
--cc=rob.krakora@messagenetsystems.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox