public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: linux-media@vger.kernel.org, stable@kernel.org
Subject: Re: [stable] [PATCH v2] V4L/DVB: budget: Oops: "BUG: unable to handle kernel NULL pointer dereference"
Date: Mon, 19 Apr 2010 11:21:40 -0700	[thread overview]
Message-ID: <20100419182140.GE32347@kroah.com> (raw)
In-Reply-To: <1269436658-20370-1-git-send-email-bjorn@mork.no>

On Wed, Mar 24, 2010 at 02:17:38PM +0100, Bjørn Mork wrote:
> Never call dvb_frontend_detach if we failed to attach a frontend. This fixes
> the following oops:
> 
> [    8.172997] DVB: registering new adapter (TT-Budget S2-1600 PCI)
> [    8.209018] adapter has MAC addr = 00:d0:5c:cc:a7:29
> [    8.328665] Intel ICH 0000:00:1f.5: PCI INT B -> GSI 17 (level, low) -> IRQ 17
> [    8.328753] Intel ICH 0000:00:1f.5: setting latency timer to 64
> [    8.562047] DVB: Unable to find symbol stv090x_attach()
> [    8.562117] BUG: unable to handle kernel NULL pointer dereference at 000000ac
> [    8.562239] IP: [<e08b04a3>] dvb_frontend_detach+0x4/0x67 [dvb_core]
> 
> Ref http://bugs.debian.org/575207
> 
> Also clean up if we are unable to register the tuner and LNB drivers
> 
> Signed-off-by: Bjørn Mork <bjorn@mork.no>
> Cc: stable@kernel.org
> Reported-by: Fladischer Michael <FladischerMichael@fladi.at>
> ---
> Oliver Endriss <o.endriss@gmx.de> writes:
> 
> > Could you please extend your patch in a way
> > that it will also catch, if
> > - dvb_attach(stv6110x_attach,...)
> > - dvb_attach(isl6423_attach,...)
> > fail?
> 
> OK.  Attempting, although I have no clue whether such failures are really
> fatal or not...
> 
> This is version 2 of this patch, adding cleanup in case we fail to register
> the two submodules used by this card/frontend.  I'm not certain that this 
> additional cleanup is appropriate for stable as any failure to register 
> these will be handled cleanly AFAICS.  But I have no way to test this.
> 
> This patch should apply cleanly to 2.6.32, 2.6.33, 2.6.34-rc2
> 
> This does not apply cleanly to git://linuxtv.org/v4l-dvb.git master.  I will 
> followup with a similar patch for that branch
> 
> Please apply to stable if appropriate.  If not, please apply version 1
> of the patch, which fixes only the oops condition.

Any reason why this patch isn't in Linus's tree yet?

thanks,

greg k-h

  parent reply	other threads:[~2010-04-19 18:32 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-03-24 10:57 [PATCH] V4L/DVB: budget: Oops: "BUG: unable to handle kernel NULL pointer dereference" Bjørn Mork
2010-03-24 12:25 ` Oliver Endriss
2010-03-24 12:30   ` Bug#575207: Info received ([PATCH] V4L/DVB: budget: Oops: "BUG: unable to handle kernel NULL pointer dereference") Debian Bug Tracking System
2010-03-24 13:17   ` [PATCH v2] V4L/DVB: budget: Oops: "BUG: unable to handle kernel NULL pointer dereference" Bjørn Mork
2010-03-24 13:30     ` [PATCH v2 for v4l-dvb master] " Bjørn Mork
2010-03-25 12:38       ` Oliver Endriss
2010-04-19 18:21     ` Greg KH [this message]
2010-04-22  8:53       ` [stable] [PATCH v2] " Bjørn Mork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100419182140.GE32347@kroah.com \
    --to=greg@kroah.com \
    --cc=bjorn@mork.no \
    --cc=linux-media@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox