From: Greg KH <greg@kroah.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Viral Mehta <Viral.Mehta@lntinfotech.com>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-media@vger.kernel.org" <linux-media@vger.kernel.org>,
"robert.lukassen@tomtom.com" <robert.lukassen@tomtom.com>
Subject: Re: [PATCH 1/2] USB gadget: video class function driver
Date: Mon, 3 May 2010 10:15:48 -0700 [thread overview]
Message-ID: <20100503171548.GA11151@kroah.com> (raw)
In-Reply-To: <201005031430.00428.laurent.pinchart@ideasonboard.com>
On Mon, May 03, 2010 at 02:29:57PM +0200, Laurent Pinchart wrote:
> Hi Viral,
>
> On Monday 03 May 2010 13:14:11 Viral Mehta wrote:
> > Hi,
> >
> > >This USB video class function driver implements a video capture device
> > >from the host's point of view. It creates a V4L2 output device on the
> > >gadget's side to transfer data from a userspace application over USB.
> > >
> > >The UVC-specific descriptors are passed by the gadget driver to the UVC
> > >function driver, making them completely configurable without any
> > >modification to the function's driver code.
> >
> > I wanted to test this code. I git cloned[1] tree. It has v4l2-event.[c,h]
> > and so I assume that now this tree has support for v4l2 event code.
> >
> > But, while compilation, I am getting this error.
> > [root@viral linux-next]# make uImage > /dev/null && make modules
> > CHK include/linux/version.h
> > CHK include/generated/utsrelease.h
> > make[1]: `include/generated/mach-types.h' is up to date.
> > CALL scripts/checksyscalls.sh
> > Building modules, stage 2.
> > MODPOST 5 modules
> > ERROR: "v4l2_event_dequeue" [drivers/usb/gadget/g_webcam.ko] undefined!
> > ERROR: "v4l2_event_init" [drivers/usb/gadget/g_webcam.ko] undefined!
> > make[1]: *** [__modpost] Error 1
> > make: *** [modules] Error 2
> >
> > And by looking at the code, those symbols are not exported and thus the
> > error is obvious. Can you please point me out where to take v4l2-event
> > code? I tried to look for on linuxtv.org but was not able to locate the
> > right code.
> >
> > [1]git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-next.git
>
> There's a patch pending on the linux-media list to export those two functions.
> It has been acked by Sakari (the author of the V4L2 events patch set), but not
> committed by Mauro to his linux-next yet. That should be a matter of days.
Do you have a pointer to that patch? I'll take it into my usb tree for
now, to keep things building, and let Mauro send it to Linus for
merging.
thanks,
greg k-h
next prev parent reply other threads:[~2010-05-03 17:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-02 18:57 [PATCH 0/2] UVC gadget driver Laurent Pinchart
2010-05-02 18:57 ` [PATCH 1/2] USB gadget: video class function driver Laurent Pinchart
2010-05-03 11:14 ` Viral Mehta
2010-05-03 12:29 ` Laurent Pinchart
2010-05-03 17:15 ` Greg KH [this message]
2010-05-03 21:17 ` Laurent Pinchart
2010-05-03 23:02 ` Mauro Carvalho Chehab
2010-05-04 4:30 ` Viral Mehta
2010-05-02 18:57 ` [PATCH 2/2] USB gadget: Webcam device Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100503171548.GA11151@kroah.com \
--to=greg@kroah.com \
--cc=Viral.Mehta@lntinfotech.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=robert.lukassen@tomtom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox