linux-media.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [patch 10/11] ir-keytable: avoid double lock
       [not found] <201004272111.o3RLBQlk020008@imap1.linux-foundation.org>
@ 2010-05-03 23:07 ` Mauro Carvalho Chehab
  2010-05-04 10:02   ` Dan Carpenter
  0 siblings, 1 reply; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2010-05-03 23:07 UTC (permalink / raw)
  To: akpm; +Cc: linux-media, error27, dtor

akpm@linux-foundation.org wrote:
> From: Dan Carpenter <error27@gmail.com>
> 
> It's possible that we wanted to resize to a smaller size but we didn't
> have enough memory to create the new table.  We need to test for that here
> so we don't try to lock twice and dead lock.  Also we free the "oldkeymap"
> on that path and that would be bad.

This patch doesn't apply anymore on my tree.

It probably conflicted with this one:

commit 2b12a23223d05a1192e1e55775b79d6caa52b066
Author: David Härdeman <david@hardeman.nu>
Date:   Fri Apr 2 15:58:28 2010 -0300

    V4L/DVB: drivers/media/IR - improve keytable code

    The attached patch rewrites much of the keytable code in
    drivers/media/IR/ir-keytable.c.


Cheers,
Mauro

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch 10/11] ir-keytable: avoid double lock
  2010-05-03 23:07 ` [patch 10/11] ir-keytable: avoid double lock Mauro Carvalho Chehab
@ 2010-05-04 10:02   ` Dan Carpenter
  0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2010-05-04 10:02 UTC (permalink / raw)
  To: Mauro Carvalho Chehab; +Cc: akpm, linux-media, dtor

On Mon, May 03, 2010 at 08:07:29PM -0300, Mauro Carvalho Chehab wrote:
> akpm@linux-foundation.org wrote:
> > From: Dan Carpenter <error27@gmail.com>
> > 
> > It's possible that we wanted to resize to a smaller size but we didn't
> > have enough memory to create the new table.  We need to test for that here
> > so we don't try to lock twice and dead lock.  Also we free the "oldkeymap"
> > on that path and that would be bad.
> 
> This patch doesn't apply anymore on my tree.
> 
> It probably conflicted with this one:
> 

Yup.  It's no longer needed.  Looks good.

regards,
dan carpenter



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-05-04 10:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <201004272111.o3RLBQlk020008@imap1.linux-foundation.org>
2010-05-03 23:07 ` [patch 10/11] ir-keytable: avoid double lock Mauro Carvalho Chehab
2010-05-04 10:02   ` Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).