* [patch -next 2/3] media/IR/imon: testing the wrong variable
@ 2010-05-04 11:38 Dan Carpenter
2010-05-04 13:55 ` Jarod Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-05-04 11:38 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Jarod Wilson, linux-media
There is a typo here. We meant to test "ir" instead of "props". The
"props" variable was tested earlier.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/IR/imon.c b/drivers/media/IR/imon.c
index b65c31a..f2066d0 100644
--- a/drivers/media/IR/imon.c
+++ b/drivers/media/IR/imon.c
@@ -1672,7 +1672,7 @@ static struct input_dev *imon_init_idev(struct imon_context *ictx)
}
ir = kzalloc(sizeof(struct ir_input_dev), GFP_KERNEL);
- if (!props) {
+ if (!ir) {
dev_err(ictx->dev, "remote ir input dev allocation failed\n");
goto ir_dev_alloc_failed;
}
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch -next 2/3] media/IR/imon: testing the wrong variable
2010-05-04 11:38 [patch -next 2/3] media/IR/imon: testing the wrong variable Dan Carpenter
@ 2010-05-04 13:55 ` Jarod Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Jarod Wilson @ 2010-05-04 13:55 UTC (permalink / raw)
To: Dan Carpenter; +Cc: Mauro Carvalho Chehab, Jarod Wilson, linux-media
On Tue, May 4, 2010 at 7:38 AM, Dan Carpenter <error27@gmail.com> wrote:
> There is a typo here. We meant to test "ir" instead of "props". The
> "props" variable was tested earlier.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Jarod Wilson <jarod@redhat.com>
--
Jarod Wilson
jarod@wilsonet.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-04 13:55 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-04 11:38 [patch -next 2/3] media/IR/imon: testing the wrong variable Dan Carpenter
2010-05-04 13:55 ` Jarod Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox