From: Dan Carpenter <error27@gmail.com>
To: Jarod Wilson <jarod@redhat.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] IR/imon: remove dead IMON_KEY_RELEASE_OFFSET
Date: Tue, 4 May 2010 18:06:41 +0200 [thread overview]
Message-ID: <20100504160641.GZ29093@bicker> (raw)
In-Reply-To: <20100504140318.GA10813@redhat.com>
On Tue, May 04, 2010 at 10:03:18AM -0400, Jarod Wilson wrote:
> @@ -1205,7 +1204,7 @@ static u32 imon_panel_key_lookup(u64 hw_code)
> if (imon_panel_key_table[i].hw_code == (code | 0xffee))
> break;
>
> - keycode = imon_panel_key_table[i % IMON_KEY_RELEASE_OFFSET].keycode;
> + keycode = imon_panel_key_table[i].keycode;
>
> return keycode;
> }
There is still potentially a problem here because if we don't hit the
break statement, then we're one past the end of the array.
regards,
dan carpenter
next prev parent reply other threads:[~2010-05-04 16:06 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 12:20 [-next] [bug report] media/IR/imon: array overflow Dan Carpenter
2010-05-04 14:03 ` [PATCH] IR/imon: remove dead IMON_KEY_RELEASE_OFFSET Jarod Wilson
2010-05-04 16:06 ` Dan Carpenter [this message]
2010-05-04 19:17 ` [PATCH v2] " Jarod Wilson
2010-05-07 11:52 ` Mauro Carvalho Chehab
2010-05-07 13:13 ` Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504160641.GZ29093@bicker \
--to=error27@gmail.com \
--cc=jarod@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).