From: Dan Carpenter <error27@gmail.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: linux-media@vger.kernel.org
Subject: [patch -next] input: unlock on error paths
Date: Wed, 5 May 2010 07:56:24 +0200 [thread overview]
Message-ID: <20100505055624.GB27064@bicker> (raw)
We can't return here directly, we need to unlock the event_lock first.
This was introduced in: edeada2cde "V4L/DVB: input: Add support for
EVIO[CS]GKEYCODEBIG"
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/input/input.c b/drivers/input/input.c
index e623edf..7c3fc5e 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -759,8 +759,9 @@ int input_set_keycode_big(struct input_dev *dev,
if (!dev->setkeycode)
goto out;
- if (input_fetch_scancode(kt_entry, &scancode))
- return -EINVAL;
+ retval = input_fetch_scancode(kt_entry, &scancode);
+ if (retval)
+ goto out;
retval = dev->getkeycode(dev, scancode,
&old_keycode);
reply other threads:[~2010-05-05 5:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100505055624.GB27064@bicker \
--to=error27@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox