Re: [PATCH 0/3] Driver for the i.MX2x CMOS Sensor Interface

[Sascha Hauer <s.hauer@pengutronix.de>]

On Fri, May 21, 2010 at 08:33:40PM +0200, Guennadi Liakhovetski wrote:
> On Fri, 21 May 2010, Baruch Siach wrote:
> 
> > Hi Sascha,
> > 
> > On Fri, May 21, 2010 at 09:20:45AM +0200, Sascha Hauer wrote:
> > > On Thu, May 06, 2010 at 04:09:38PM +0300, Baruch Siach wrote:
> > > > This series contains a soc_camera driver for the i.MX25/i.MX27 CSI device, and 
> > > > platform code for the i.MX25 and i.MX27 chips. This driver is based on a driver 
> > > > for i.MX27 CSI from Sascha Hauer, that  Alan Carvalho de Assis has posted in 
> > > > linux-media last December[1]. Since all I have is a i.MX25 PDK paltform I can't 
> > > > test the mx27 specific code. Testers and comment are welcome.
> > > > 
> > > > [1] https://patchwork.kernel.org/patch/67636/
> > > > 
> > > > Baruch Siach (3):
> > > >   mx2_camera: Add soc_camera support for i.MX25/i.MX27
> > > >   mx27: add support for the CSI device
> > > >   mx25: add support for the CSI device
> > > 
> > > With the two additions I sent I can confirm this working on i.MX27, so
> > > no need to remove the related code.
> > 
> > Thanks. I'll add your patches to my queue and resend the series next week.
> 
> Firstly, Sascha, unfortunately, you've forgotten to CC the maintainer, 
> that will have to deal with these patches.
> 
> Secondly, I don't think that's a good idea to submit mx27 fixes as 
> incremental patches. I'd prefer to have them rolled into the actual driver 
> submission patches, where Sascha would just add his Sob / acked-by / 
> tested-by / whatever... Or you can first submit an mx25-only driver and 
> let Sascha add mx27 to it, in which case this would be a functionality 
> extension, but not a fix of a broken driver.

My intention with these fixes was that Baruch integrates them into his
patch (which he did).

Sascha


-- 
Pengutronix e.K.                           |                             |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |