* [patch v3 2/2] video/saa7134: remove duplicate break
@ 2010-05-25 9:21 Dan Carpenter
2010-05-26 12:43 ` Jean Delvare
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2010-05-25 9:21 UTC (permalink / raw)
To: Jean Delvare
Cc: Mauro Carvalho Chehab, Beholder Intl. Ltd. Dmitry Belimov,
hermann pitton, Douglas Schilling Landgraf, linux-media,
kernel-janitors
The original code had two break statements in a row.
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
v3: Put this in a seperate patch.
diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
index e5565e2..7691bf2 100644
--- a/drivers/media/video/saa7134/saa7134-input.c
+++ b/drivers/media/video/saa7134/saa7134-input.c
@@ -815,7 +815,6 @@ int saa7134_input_init1(struct saa7134_dev *dev)
mask_keyup = 0x020000;
polling = 50; /* ms */
break;
- break;
}
if (NULL == ir_codes) {
printk("%s: Oops: IR config error [card=%d]\n",
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [patch v3 2/2] video/saa7134: remove duplicate break
2010-05-25 9:21 [patch v3 2/2] video/saa7134: remove duplicate break Dan Carpenter
@ 2010-05-26 12:43 ` Jean Delvare
0 siblings, 0 replies; 2+ messages in thread
From: Jean Delvare @ 2010-05-26 12:43 UTC (permalink / raw)
To: Dan Carpenter
Cc: Mauro Carvalho Chehab, Beholder Intl. Ltd. Dmitry Belimov,
hermann pitton, Douglas Schilling Landgraf, linux-media,
kernel-janitors
On Tue, 25 May 2010 11:21:50 +0200, Dan Carpenter wrote:
> The original code had two break statements in a row.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
Acked-by: Jean Delvare <khali@linux-fr.org>
> ---
> v3: Put this in a seperate patch.
>
> diff --git a/drivers/media/video/saa7134/saa7134-input.c b/drivers/media/video/saa7134/saa7134-input.c
> index e5565e2..7691bf2 100644
> --- a/drivers/media/video/saa7134/saa7134-input.c
> +++ b/drivers/media/video/saa7134/saa7134-input.c
> @@ -815,7 +815,6 @@ int saa7134_input_init1(struct saa7134_dev *dev)
> mask_keyup = 0x020000;
> polling = 50; /* ms */
> break;
> - break;
> }
> if (NULL == ir_codes) {
> printk("%s: Oops: IR config error [card=%d]\n",
>
--
Jean Delvare
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-05-26 12:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-05-25 9:21 [patch v3 2/2] video/saa7134: remove duplicate break Dan Carpenter
2010-05-26 12:43 ` Jean Delvare
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).