[PATCH] Compro videomate T750F DVB-T mode works now

[PATCH] Compro videomate T750F DVB-T mode works now

[Emard]

HI

... tried to post this few times to thhis list I don't know if
it has made it maybe this time it will appear on the mailing list....

I have european version of Compro Videomate T750F Vista
hybrid dvb-t + tv (PAL) + FM card. In kernels up to date (2.6.33.3)
it didn't want to initialize in analog mode (tuner xc2028 always failed).

Here's sligthly adapted patch from
http://www.linuxtv.org/pipermail/linux-dvb/2008-May/025945.html
that works for me. It disables analog tuner xc2028 which doesn't
work (maybe because current driver is only for ntsc version of the
card) and enables digital tuner that consists of zarlink 10353 and
qt1010. Tested and works on kernel 2.6.33.3

Best regards, Emard

--- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c.orig	2010-05-02 00:06:45.000000000 +0200
+++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c	2010-05-02 01:20:50.000000000 +0200
@@ -4883,10 +4883,11 @@ struct saa7134_board saa7134_boards[] =
 		/* John Newbigin <jn@it.swin.edu.au> */
 		.name           = "Compro VideoMate T750",
 		.audio_clock    = 0x00187de7,
-		.tuner_type     = TUNER_XC2028,
+		.tuner_type     = TUNER_ABSENT,
 		.radio_type     = UNSET,
 		.tuner_addr	= ADDR_UNSET,
 		.radio_addr	= ADDR_UNSET,
+		.mpeg           = SAA7134_MPEG_DVB,
 		.inputs = {{
 			.name   = name_tv,
 			.vmux   = 3,
@@ -7192,6 +7193,7 @@ int saa7134_board_init2(struct saa7134_d
 	case SAA7134_BOARD_AVERMEDIA_SUPER_007:
 	case SAA7134_BOARD_TWINHAN_DTV_DVB_3056:
 	case SAA7134_BOARD_CREATIX_CTX953:
+        case SAA7134_BOARD_VIDEOMATE_T750:
 	{
 		/* this is a hybrid board, initialize to analog mode
 		 * and configure firmware eeprom address
--- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c.orig	2010-05-01 23:57:08.000000000 +0200
+++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c	2010-05-02 00:51:44.000000000 +0200
@@ -55,6 +55,7 @@
 #include "tda8290.h"
 
 #include "zl10353.h"
+#include "qt1010.h"
 
 #include "zl10036.h"
 #include "zl10039.h"
@@ -886,6 +887,17 @@ static struct zl10353_config behold_x7_c
 	.disable_i2c_gate_ctrl = 1,
 };
 
+static struct zl10353_config videomate_t750_zl10353_config = {
+       .demod_address  = 0x0f,
+       .no_tuner = 1,
+       .parallel_ts = 1,
+};
+
+static struct qt1010_config videomate_t750_qt1010_config = {
+       .i2c_address = 0x62
+};
+
+
 /* ==================================================================
  * tda10086 based DVB-S cards, helper functions
  */
@@ -1556,6 +1568,26 @@ static int dvb_init(struct saa7134_dev *
 					__func__);
 
 		break;
+        /*FIXME: What frontend does Videomate T750 use? */
+        case SAA7134_BOARD_VIDEOMATE_T750:
+                printk("Compro VideoMate T750 DVB setup\n");
+                fe0->dvb.frontend = dvb_attach(zl10353_attach,
+                                                &videomate_t750_zl10353_config,
+                                                &dev->i2c_adap);
+                if (fe0->dvb.frontend != NULL) {
+                        printk("Attaching pll\n");
+                        // if there is a gate function then the i2c bus breaks.....!
+                        fe0->dvb.frontend->ops.i2c_gate_ctrl = 0;
+ 
+                        if (dvb_attach(qt1010_attach,
+                                       fe0->dvb.frontend,
+                                       &dev->i2c_adap,
+                                       &videomate_t750_qt1010_config) == NULL)
+                        {
+                                wprintk("error attaching QT1010\n");
+                        }
+                }
+                break;
 	case SAA7134_BOARD_ZOLID_HYBRID_PCI:
 		fe0->dvb.frontend = dvb_attach(tda10048_attach,
 					       &zolid_tda10048_config,

Re: [PATCH] Compro videomate T750F DVB-T mode works now

[Mauro Carvalho Chehab]

Em Sat, 8 May 2010 01:50:24 +0200
Emard <davoremard@gmail.com> escreveu:

> HI
> 
> ... tried to post this few times to thhis list I don't know if
> it has made it maybe this time it will appear on the mailing list....
> 
> I have european version of Compro Videomate T750F Vista
> hybrid dvb-t + tv (PAL) + FM card. In kernels up to date (2.6.33.3)
> it didn't want to initialize in analog mode (tuner xc2028 always failed).
> 
> Here's sligthly adapted patch from
> http://www.linuxtv.org/pipermail/linux-dvb/2008-May/025945.html
> that works for me. It disables analog tuner xc2028 which doesn't
> work (maybe because current driver is only for ntsc version of the
> card) and enables digital tuner that consists of zarlink 10353 and
> qt1010. Tested and works on kernel 2.6.33.3

xc2028 tuner driver supports PAL standards as well. If it is not working fine,
it is probably because the GPIO's are wrong. You need to run REGSPY.EXE program,
from DScaler project, to get the proper gpio values for your board.

Btw, please send your Signed-off-by: on your patches.
> 
> Best regards, Emard
> 
> --- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c.orig	2010-05-02 00:06:45.000000000 +0200
> +++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c	2010-05-02 01:20:50.000000000 +0200
> @@ -4883,10 +4883,11 @@ struct saa7134_board saa7134_boards[] =
>  		/* John Newbigin <jn@it.swin.edu.au> */
>  		.name           = "Compro VideoMate T750",
>  		.audio_clock    = 0x00187de7,
> -		.tuner_type     = TUNER_XC2028,
> +		.tuner_type     = TUNER_ABSENT,

Instead of touching at the existing entry, you should be adding a new one, with
your board specifics, otherwise your patch would break support for the other
board variant.

>  		.radio_type     = UNSET,
>  		.tuner_addr	= ADDR_UNSET,
>  		.radio_addr	= ADDR_UNSET,
> +		.mpeg           = SAA7134_MPEG_DVB,
>  		.inputs = {{
>  			.name   = name_tv,
>  			.vmux   = 3,
> @@ -7192,6 +7193,7 @@ int saa7134_board_init2(struct saa7134_d
>  	case SAA7134_BOARD_AVERMEDIA_SUPER_007:
>  	case SAA7134_BOARD_TWINHAN_DTV_DVB_3056:
>  	case SAA7134_BOARD_CREATIX_CTX953:
> +        case SAA7134_BOARD_VIDEOMATE_T750:
>  	{
>  		/* this is a hybrid board, initialize to analog mode
>  		 * and configure firmware eeprom address
> --- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c.orig	2010-05-01 23:57:08.000000000 +0200
> +++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c	2010-05-02 00:51:44.000000000 +0200
> @@ -55,6 +55,7 @@
>  #include "tda8290.h"
>  
>  #include "zl10353.h"
> +#include "qt1010.h"
>  
>  #include "zl10036.h"
>  #include "zl10039.h"
> @@ -886,6 +887,17 @@ static struct zl10353_config behold_x7_c
>  	.disable_i2c_gate_ctrl = 1,
>  };
>  
> +static struct zl10353_config videomate_t750_zl10353_config = {
> +       .demod_address  = 0x0f,
> +       .no_tuner = 1,
> +       .parallel_ts = 1,
> +};
> +
> +static struct qt1010_config videomate_t750_qt1010_config = {
> +       .i2c_address = 0x62
> +};
> +
> +
>  /* ==================================================================
>   * tda10086 based DVB-S cards, helper functions
>   */
> @@ -1556,6 +1568,26 @@ static int dvb_init(struct saa7134_dev *
>  					__func__);
>  
>  		break;
> +        /*FIXME: What frontend does Videomate T750 use? */
> +        case SAA7134_BOARD_VIDEOMATE_T750:
> +                printk("Compro VideoMate T750 DVB setup\n");
> +                fe0->dvb.frontend = dvb_attach(zl10353_attach,
> +                                                &videomate_t750_zl10353_config,
> +                                                &dev->i2c_adap);
> +                if (fe0->dvb.frontend != NULL) {
> +                        printk("Attaching pll\n");
> +                        // if there is a gate function then the i2c bus breaks.....!
> +                        fe0->dvb.frontend->ops.i2c_gate_ctrl = 0;
> + 
> +                        if (dvb_attach(qt1010_attach,
> +                                       fe0->dvb.frontend,
> +                                       &dev->i2c_adap,
> +                                       &videomate_t750_qt1010_config) == NULL)
> +                        {
> +                                wprintk("error attaching QT1010\n");
> +                        }
> +                }
> +                break;
>  	case SAA7134_BOARD_ZOLID_HYBRID_PCI:
>  		fe0->dvb.frontend = dvb_attach(tda10048_attach,
>  					       &zolid_tda10048_config,
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 

Cheers,
Mauro

Re: [PATCH] Compro videomate T750F DVB-T mode works now

[hermann pitton]

Hi,

Am Donnerstag, den 27.05.2010, 14:17 -0300 schrieb Mauro Carvalho
Chehab:
> Em Sat, 8 May 2010 01:50:24 +0200
> Emard <davoremard@gmail.com> escreveu:
> 
> > HI
> > 
> > ... tried to post this few times to thhis list I don't know if
> > it has made it maybe this time it will appear on the mailing list....
> > 
> > I have european version of Compro Videomate T750F Vista
> > hybrid dvb-t + tv (PAL) + FM card. In kernels up to date (2.6.33.3)
> > it didn't want to initialize in analog mode (tuner xc2028 always failed).
> > 
> > Here's sligthly adapted patch from
> > http://www.linuxtv.org/pipermail/linux-dvb/2008-May/025945.html
> > that works for me. It disables analog tuner xc2028 which doesn't
> > work (maybe because current driver is only for ntsc version of the
> > card) and enables digital tuner that consists of zarlink 10353 and
> > qt1010. Tested and works on kernel 2.6.33.3
> 
> xc2028 tuner driver supports PAL standards as well. If it is not working fine,
> it is probably because the GPIO's are wrong. You need to run REGSPY.EXE program,
> from DScaler project, to get the proper gpio values for your board.
> 
> Btw, please send your Signed-off-by: on your patches.
> > 
> > Best regards, Emard
> > 
> > --- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c.orig	2010-05-02 00:06:45.000000000 +0200
> > +++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c	2010-05-02 01:20:50.000000000 +0200
> > @@ -4883,10 +4883,11 @@ struct saa7134_board saa7134_boards[] =
> >  		/* John Newbigin <jn@it.swin.edu.au> */
> >  		.name           = "Compro VideoMate T750",
> >  		.audio_clock    = 0x00187de7,
> > -		.tuner_type     = TUNER_XC2028,
> > +		.tuner_type     = TUNER_ABSENT,
> 
> Instead of touching at the existing entry, you should be adding a new one, with
> your board specifics, otherwise your patch would break support for the other
> board variant.
> 
> >  		.radio_type     = UNSET,
> >  		.tuner_addr	= ADDR_UNSET,
> >  		.radio_addr	= ADDR_UNSET,
> > +		.mpeg           = SAA7134_MPEG_DVB,
> >  		.inputs = {{
> >  			.name   = name_tv,
> >  			.vmux   = 3,
> > @@ -7192,6 +7193,7 @@ int saa7134_board_init2(struct saa7134_d
> >  	case SAA7134_BOARD_AVERMEDIA_SUPER_007:
> >  	case SAA7134_BOARD_TWINHAN_DTV_DVB_3056:
> >  	case SAA7134_BOARD_CREATIX_CTX953:
> > +        case SAA7134_BOARD_VIDEOMATE_T750:
> >  	{
> >  		/* this is a hybrid board, initialize to analog mode
> >  		 * and configure firmware eeprom address
> > --- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c.orig	2010-05-01 23:57:08.000000000 +0200
> > +++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-dvb.c	2010-05-02 00:51:44.000000000 +0200
> > @@ -55,6 +55,7 @@
> >  #include "tda8290.h"
> >  
> >  #include "zl10353.h"
> > +#include "qt1010.h"
> >  
> >  #include "zl10036.h"
> >  #include "zl10039.h"
> > @@ -886,6 +887,17 @@ static struct zl10353_config behold_x7_c
> >  	.disable_i2c_gate_ctrl = 1,
> >  };
> >  
> > +static struct zl10353_config videomate_t750_zl10353_config = {
> > +       .demod_address  = 0x0f,
> > +       .no_tuner = 1,
> > +       .parallel_ts = 1,
> > +};
> > +
> > +static struct qt1010_config videomate_t750_qt1010_config = {
> > +       .i2c_address = 0x62
> > +};
> > +
> > +
> >  /* ==================================================================
> >   * tda10086 based DVB-S cards, helper functions
> >   */
> > @@ -1556,6 +1568,26 @@ static int dvb_init(struct saa7134_dev *
> >  					__func__);
> >  
> >  		break;
> > +        /*FIXME: What frontend does Videomate T750 use? */
> > +        case SAA7134_BOARD_VIDEOMATE_T750:
> > +                printk("Compro VideoMate T750 DVB setup\n");
> > +                fe0->dvb.frontend = dvb_attach(zl10353_attach,
> > +                                                &videomate_t750_zl10353_config,
> > +                                                &dev->i2c_adap);
> > +                if (fe0->dvb.frontend != NULL) {
> > +                        printk("Attaching pll\n");
> > +                        // if there is a gate function then the i2c bus breaks.....!
> > +                        fe0->dvb.frontend->ops.i2c_gate_ctrl = 0;
> > + 
> > +                        if (dvb_attach(qt1010_attach,
> > +                                       fe0->dvb.frontend,
> > +                                       &dev->i2c_adap,
> > +                                       &videomate_t750_qt1010_config) == NULL)
> > +                        {
> > +                                wprintk("error attaching QT1010\n");
> > +                        }
> > +                }
> > +                break;
> >  	case SAA7134_BOARD_ZOLID_HYBRID_PCI:
> >  		fe0->dvb.frontend = dvb_attach(tda10048_attach,
> >  					       &zolid_tda10048_config,

just for reference, here is a link about what we tried last summer.

The followups do have also some regspy logs.

http://www.mail-archive.com/linux-media@vger.kernel.org/msg07478.html

Cheers,
Hermann

Re: [PATCH] Compro videomate T750F DVB-T mode works now

[Davor Emard]

On Thu, May 27, 2010 at 02:17:04PM -0300, Mauro Carvalho Chehab wrote:
> Em Sat, 8 May 2010 01:50:24 +0200
> Emard <davoremard@gmail.com> escreveu:
> 
> > HI
> > 
> > ... tried to post this few times to thhis list I don't know if
> > it has made it maybe this time it will appear on the mailing list....
> > 
> > I have european version of Compro Videomate T750F Vista
> > hybrid dvb-t + tv (PAL) + FM card. In kernels up to date (2.6.33.3)
> > it didn't want to initialize in analog mode (tuner xc2028 always failed).
> > 
> > Here's sligthly adapted patch from
> > http://www.linuxtv.org/pipermail/linux-dvb/2008-May/025945.html
> > that works for me. It disables analog tuner xc2028 which doesn't
> > work (maybe because current driver is only for ntsc version of the
> > card) and enables digital tuner that consists of zarlink 10353 and
> > qt1010. Tested and works on kernel 2.6.33.3
> 
> xc2028 tuner driver supports PAL standards as well. If it is not working fine,
> it is probably because the GPIO's are wrong. You need to run REGSPY.EXE program,
> from DScaler project, to get the proper gpio values for your board.
> 
> Btw, please send your Signed-off-by: on your patches.
> > 
> > Best regards, Emard
> > 
> > --- linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c.orig	2010-05-02 00:06:45.000000000 +0200
> > +++ linux-2.6.33.3/drivers/media/video/saa7134/saa7134-cards.c	2010-05-02 01:20:50.000000000 +0200
> > @@ -4883,10 +4883,11 @@ struct saa7134_board saa7134_boards[] =
> >  		/* John Newbigin <jn@it.swin.edu.au> */
> >  		.name           = "Compro VideoMate T750",
> >  		.audio_clock    = 0x00187de7,
> > -		.tuner_type     = TUNER_XC2028,
> > +		.tuner_type     = TUNER_ABSENT,

HI!

Ignore this patch, this is early version that breaks analog part just
to get dvb-t working. 

I had posted improved patch (I called it v17, should be on this list as well) 
with early supports for both analog dvb-t and radio on 2.6.33.4 (also the remote, but the 
IR system had changed so we may fix remote later... but that's easy :). We
have another issues

Patch v17 which works on my case from cold reboot and at least first
time VDR is started. Subsequent restarts of VDR may prevent DVB-T tuner
from changing frequency - it stays and receives the previos frequency
at which VDR stopped. But sometimes after frew minutes VDR starts working
again tuning to different freq - strange behaviour really maybe it's not
only because of compro patch, could be firmware issue too)

While Samuel is testing this he had some positive results but so far but he needs 
to preinitialize the card with window$ before the firmware gets loaded :(.
I don't need this (anyway my motherboard removes PCI power for 2 seconds during 
restart so I even cannot try such intialization method)

Emard

Re: [PATCH] Compro videomate T750F DVB-T mode works now

[Davor Emard]

> just for reference, here is a link about what we tried last summer.
> 
> The followups do have also some regspy logs.
> 
> http://www.mail-archive.com/linux-media@vger.kernel.org/msg07478.html
> 

HI, thanks I have see your posts about this but have not yet carefully 
studied this sniffage of what window$ does to the card. I think we have
to re-look at this and try to closely copy this GPIO activity in order
to more reliably initialize the card

Emard