From: Mauro Carvalho Chehab <mchehab@redhat.com>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 06/11] V4L/DVB: omap_vout: Storage class should be before const qualifier
Date: Sat, 29 May 2010 01:22:42 -0300 [thread overview]
Message-ID: <20100529012242.0ef3cdf2@pedra> (raw)
In-Reply-To: <1274344588-9034-1-git-send-email-tklauser@distanz.ch>
Em Thu, 20 May 2010 10:36:28 +0200
Tobias Klauser <tklauser@distanz.ch> escreveu:
> The C99 specification states in section 6.11.5:
>
> The placement of a storage-class specifier other than at the beginning
> of the declaration specifiers in a declaration is an obsolescent
> feature.
>
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
As you've c/c kernel-janitors, I'm assuming that this patch will go via trivial
tree. So, that's my ack:
Acked-by: Mauro Carvalho Chehab <mchehab@redhat.com>
> ---
> drivers/media/video/omap/omap_vout.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c
> index 4c0ab49..d6a2ae1 100644
> --- a/drivers/media/video/omap/omap_vout.c
> +++ b/drivers/media/video/omap/omap_vout.c
> @@ -128,7 +128,7 @@ module_param(debug, bool, S_IRUGO);
> MODULE_PARM_DESC(debug, "Debug level (0-1)");
>
> /* list of image formats supported by OMAP2 video pipelines */
> -const static struct v4l2_fmtdesc omap_formats[] = {
> +static const struct v4l2_fmtdesc omap_formats[] = {
> {
> /* Note: V4L2 defines RGB565 as:
> *
--
Cheers,
Mauro
next prev parent reply other threads:[~2010-05-29 4:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-20 8:36 [PATCH 06/11] V4L/DVB: omap_vout: Storage class should be before const qualifier Tobias Klauser
2010-05-29 4:22 ` Mauro Carvalho Chehab [this message]
2010-05-31 7:58 ` Hiremath, Vaibhav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100529012242.0ef3cdf2@pedra \
--to=mchehab@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=tklauser@distanz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox