From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:13422 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750858Ab0E2EWt (ORCPT ); Sat, 29 May 2010 00:22:49 -0400 Date: Sat, 29 May 2010 01:22:42 -0300 From: Mauro Carvalho Chehab To: Tobias Klauser Cc: linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH 06/11] V4L/DVB: omap_vout: Storage class should be before const qualifier Message-ID: <20100529012242.0ef3cdf2@pedra> In-Reply-To: <1274344588-9034-1-git-send-email-tklauser@distanz.ch> References: <1274344588-9034-1-git-send-email-tklauser@distanz.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Thu, 20 May 2010 10:36:28 +0200 Tobias Klauser escreveu: > The C99 specification states in section 6.11.5: > > The placement of a storage-class specifier other than at the beginning > of the declaration specifiers in a declaration is an obsolescent > feature. > > Signed-off-by: Tobias Klauser As you've c/c kernel-janitors, I'm assuming that this patch will go via trivial tree. So, that's my ack: Acked-by: Mauro Carvalho Chehab > --- > drivers/media/video/omap/omap_vout.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/media/video/omap/omap_vout.c b/drivers/media/video/omap/omap_vout.c > index 4c0ab49..d6a2ae1 100644 > --- a/drivers/media/video/omap/omap_vout.c > +++ b/drivers/media/video/omap/omap_vout.c > @@ -128,7 +128,7 @@ module_param(debug, bool, S_IRUGO); > MODULE_PARM_DESC(debug, "Debug level (0-1)"); > > /* list of image formats supported by OMAP2 video pipelines */ > -const static struct v4l2_fmtdesc omap_formats[] = { > +static const struct v4l2_fmtdesc omap_formats[] = { > { > /* Note: V4L2 defines RGB565 as: > * -- Cheers, Mauro