From: Dan Carpenter <error27@gmail.com>
To: Antti Palosaari <crope@iki.fi>
Cc: linux-media@vger.kernel.org
Subject: Re: dereferencing uninitialized variable in anysee_probe()
Date: Mon, 31 May 2010 21:13:23 +0200 [thread overview]
Message-ID: <20100531191323.GY5483@bicker> (raw)
In-Reply-To: <4C03D449.2020507@iki.fi>
On Mon, May 31, 2010 at 06:22:49PM +0300, Antti Palosaari wrote:
> Terve Dan,
>
> On 05/31/2010 06:09 PM, Dan Carpenter wrote:
>> Hi I'm going through some smatch stuff and I had a question.
>>
>> drivers/media/dvb/dvb-usb/anysee.c +482 anysee_probe(30)
>> warn: variable dereferenced before check 'd'
>>
>> 466 ret = dvb_usb_device_init(intf,&anysee_properties, THIS_MODULE,&d,
>> 467 adapter_nr);
>>
>> If we're in a cold state then dvb_usb_device_init() can return
>> zero but d is uninitialized here.
>
> Anysee is always warm. Its USB-bridge, Cypress FX2, uploads firmware
> from eeprom and due to that it is never cold from the drivers point of
> view.
>
> *cold means device needs firmware upload from driver
> *warm means device is ready. Firmware is already uploaded or it is not
> needed at all.
>
Wow. Thanks for the quick response. I was just auditing the code and
noticed some extra null checking which made me confused. I'll send a
patch for that.
regards,
dan carpenter
prev parent reply other threads:[~2010-05-31 19:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-31 15:09 dereferencing uninitialized variable in anysee_probe() Dan Carpenter
2010-05-31 15:22 ` Antti Palosaari
2010-05-31 19:13 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100531191323.GY5483@bicker \
--to=error27@gmail.com \
--cc=crope@iki.fi \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox