From: Dan Carpenter <error27@gmail.com>
To: Mauro Carvalho Chehab <mchehab@infradead.org>
Cc: Michael Krufky <mkrufky@kernellabs.com>,
"Igor M. Liplianin" <liplianin@me.by>,
Abylay Ospan <aospan@netup.ru>,
Steven Toth <stoth@kernellabs.com>,
linux-media@vger.kernel.org
Subject: [patch] V4L/DVB: cx23885: reversed condition in dvb_register()
Date: Sat, 5 Jun 2010 14:05:29 +0200 [thread overview]
Message-ID: <20100605120529.GK5483@bicker> (raw)
videobuf_dvb_register_bus() returns negative error codes on failure. This
was introduced in e4425eab6b2: "V4L/DVB: cx23885: Check register errors".
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
I don't have the hardware to test this, but it looks reversed.
diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c
index 0a199d7..bf7c328 100644
--- a/drivers/media/video/cx23885/cx23885-dvb.c
+++ b/drivers/media/video/cx23885/cx23885-dvb.c
@@ -991,7 +991,7 @@ static int dvb_register(struct cx23885_tsport *port)
ret = videobuf_dvb_register_bus(&port->frontends, THIS_MODULE, port,
&dev->pci->dev, adapter_nr, 0,
cx23885_dvb_fe_ioctl_override);
- if (!ret)
+ if (ret < 0)
return ret;
/* init CI & MAC */
reply other threads:[~2010-06-05 12:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100605120529.GK5483@bicker \
--to=error27@gmail.com \
--cc=aospan@netup.ru \
--cc=linux-media@vger.kernel.org \
--cc=liplianin@me.by \
--cc=mchehab@infradead.org \
--cc=mkrufky@kernellabs.com \
--cc=stoth@kernellabs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox