* [patch] V4L/DVB: cx23885: reversed condition in dvb_register()
@ 2010-06-05 12:05 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2010-06-05 12:05 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Michael Krufky, Igor M. Liplianin, Abylay Ospan, Steven Toth,
linux-media
videobuf_dvb_register_bus() returns negative error codes on failure. This
was introduced in e4425eab6b2: "V4L/DVB: cx23885: Check register errors".
Signed-off-by: Dan Carpenter <error27@gmail.com>
---
I don't have the hardware to test this, but it looks reversed.
diff --git a/drivers/media/video/cx23885/cx23885-dvb.c b/drivers/media/video/cx23885/cx23885-dvb.c
index 0a199d7..bf7c328 100644
--- a/drivers/media/video/cx23885/cx23885-dvb.c
+++ b/drivers/media/video/cx23885/cx23885-dvb.c
@@ -991,7 +991,7 @@ static int dvb_register(struct cx23885_tsport *port)
ret = videobuf_dvb_register_bus(&port->frontends, THIS_MODULE, port,
&dev->pci->dev, adapter_nr, 0,
cx23885_dvb_fe_ioctl_override);
- if (!ret)
+ if (ret < 0)
return ret;
/* init CI & MAC */
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2010-06-05 12:06 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-06-05 12:05 [patch] V4L/DVB: cx23885: reversed condition in dvb_register() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).