Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

[Stefan Lippers-Hollmann]

Hi

On Friday 30 April 2010, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a summary report
> of recent regressions.
> 
> The following bug entry is on the current list of known regressions
> from 2.6.33.  Please verify if it still should be listed and let the tracking team
> know (either way).
> 
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=15589
> Subject		: 2.6.34-rc1: Badness at fs/proc/generic.c:316
> Submitter	: Christian Kujau <lists@nerdbynature.de>
> Date		: 2010-03-13 23:53 (38 days old)
> Message-ID	: <alpine.DEB.2.01.1003131544340.5493@bogon.housecafe.de>
> References	: http://marc.info/?l=linux-kernel&m=126852442903680&w=2

This also continues to be a problem with b2c2-flexcop and 2.6.34-rc5-git10:

[   10.119807] b2c2-flexcop: B2C2 FlexcopII/II(b)/III digital TV receiver chip loaded successfully
[   10.129183] flexcop-pci: will use the HW PID filter.
[   10.129187] flexcop-pci: card revision 2
[   10.129195] b2c2_flexcop_pci 0000:06:01.0: PCI INT A -> GSI 19 (level, low) -> IRQ 19
[   10.129239] ------------[ cut here ]------------
[   10.129244] WARNING: at /tmp/buildd/linux-sidux-2.6-2.6.34~rc5/debian/build/source_amd64_none/fs/proc/generic.c:317 __xlate_proc_name+0xb5/0xd0()
[   10.129246] Hardware name: EP45-DS3
[   10.129247] name 'Technisat/B2C2 FlexCop II/IIb/III Digital TV PCI Driver'
[   10.129248] Modules linked in: b2c2_flexcop_pci(+) ath9k_common b2c2_flexcop v4l1_compat snd_timer radeon(+) dvb_core ar9170usb(+) ath9k_hw snd_seq_device ir_common tveeprom ttm v4l2_compat_ioctl32 snd drm_kms_helper ir_core ath mac80211 soundcore videobuf_dma_sg cx24123 drm i2c_i801 i2c_algo_bit snd_page_alloc videobuf_core cx24113 s5h1420 cfg80211 rfkill evdev i2c_core tpm_tis btcx_risc tpm led_class pcspkr tpm_bios rtc_cmos button rtc_core intel_agp rtc_lib processor ext4 mbcache jbd2 crc16 dm_mod sg sr_mod cdrom sd_mod usbhid hid uhci_hcd firewire_ohci firewire_core ahci r8169 ehci_hcd mii libata crc_itu_t scsi_mod thermal usbcore nls_base [last unloaded: scsi_wait_scan]
[   10.129279] Pid: 1124, comm: modprobe Not tainted 2.6.34-rc5-sidux-amd64 #1
[   10.129281] Call Trace:
[   10.129285]  [<ffffffff8104ba83>] ? warn_slowpath_common+0x73/0xb0
[   10.129287]  [<ffffffff8104bb20>] ? warn_slowpath_fmt+0x40/0x50
[   10.129290]  [<ffffffff8114f545>] ? __xlate_proc_name+0xb5/0xd0
[   10.129292]  [<ffffffff8114fb2e>] ? __proc_create+0x7e/0x150
[   10.129294]  [<ffffffff811504e7>] ? proc_mkdir_mode+0x27/0x60
[   10.129297]  [<ffffffff8109fb55>] ? register_handler_proc+0x115/0x130
[   10.129300]  [<ffffffff8109d4c1>] ? __setup_irq+0x1d1/0x330
[   10.129303]  [<ffffffffa011b160>] ? flexcop_pci_isr+0x0/0x190 [b2c2_flexcop_pci]
[   10.129305]  [<ffffffff8109d735>] ? request_threaded_irq+0x115/0x1b0
[   10.129308]  [<ffffffffa011b495>] ? flexcop_pci_probe+0x1a5/0x330 [b2c2_flexcop_pci]
[   10.129312]  [<ffffffff811ceef2>] ? local_pci_probe+0x12/0x20
[   10.129314]  [<ffffffff811d02ca>] ? pci_device_probe+0x10a/0x130
[   10.129317]  [<ffffffff8125cdda>] ? driver_sysfs_add+0x5a/0x80
[   10.129320]  [<ffffffff8125cf03>] ? driver_probe_device+0x93/0x190
[   10.129322]  [<ffffffff8125d093>] ? __driver_attach+0x93/0xa0
[   10.129324]  [<ffffffff8125d000>] ? __driver_attach+0x0/0xa0
[   10.129326]  [<ffffffff8125c638>] ? bus_for_each_dev+0x58/0x80
[   10.129328]  [<ffffffff8125be70>] ? bus_add_driver+0xb0/0x250
[   10.129330]  [<ffffffff8125d38a>] ? driver_register+0x6a/0x130
[   10.129332]  [<ffffffff811d056c>] ? __pci_register_driver+0x4c/0xc0
[   10.129335]  [<ffffffffa012e000>] ? flexcop_pci_module_init+0x0/0x20 [b2c2_flexcop_pci]
[   10.129338]  [<ffffffff81002044>] ? do_one_initcall+0x34/0x1a0
[   10.129341]  [<ffffffff8107d15f>] ? sys_init_module+0xdf/0x260
[   10.129344]  [<ffffffff81009f42>] ? system_call_fastpath+0x16/0x1b
[   10.129345] ---[ end trace 370a62256537c67a ]---
[   10.134144] DVB: registering new adapter (FlexCop Digital TV device)
[   10.135610] b2c2-flexcop: MAC address = 00:d0:d7:0c:83:d6

Regards
	Stefan Lippers-Hollmann

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

[Stefan Lippers-Hollmann]

Hi

On Wednesday 05 May 2010, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a summary report
> of recent regressions.
> 
> The following bug entry is on the current list of known regressions
> from 2.6.33.  Please verify if it still should be listed and let the tracking team
> know (either way).
> 
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=15589
> Subject		: 2.6.34-rc1: Badness at fs/proc/generic.c:316
> Submitter	: Christian Kujau <lists@nerdbynature.de>
> Date		: 2010-03-13 23:53 (53 days old)
> Message-ID	: <alpine.DEB.2.01.1003131544340.5493@bogon.housecafe.de>
> References	: http://marc.info/?l=linux-kernel&m=126852442903680&w=2

Still valid for b2c2_flexcop_pci in 2.6.34-rc6-git2:

[    8.736930] Linux video capture interface: v2.00
[    8.809720] b2c2-flexcop: B2C2 FlexcopII/II(b)/III digital TV receiver chip loaded successfully
[    8.818680] flexcop-pci: will use the HW PID filter.
[    8.818685] flexcop-pci: card revision 2
[    8.818694] b2c2_flexcop_pci 0000:06:01.0: PCI INT A -> GSI 19 (level, low) -> IRQ 19
[    8.818794] ------------[ cut here ]------------
[    8.818799] WARNING: at /tmp/buildd/linux-sidux-2.6-2.6.34~rc6-git2/debian/build/source_amd64_none/fs/proc/generic.c:317 __xlate_proc_name+0xb5/0xd0()
[    8.818801] Hardware name: EP45-DS3
[    8.818802] name 'Technisat/B2C2 FlexCop II/IIb/III Digital TV PCI Driver'
[    8.818804] Modules linked in: b2c2_flexcop_pci(+) cx88xx b2c2_flexcop rfkill v4l2_common ir_common videodev drm snd_pcm snd_seq rtc_cmos snd_timer rtc_core snd_seq_device rtc_lib v4l1_compat tveeprom v4l2_compat_ioctl32 ir_core dvb_core snd videobuf_dma_sg cx24123 cx24113 videobuf_core s5h1420 tpm_tis led_class btcx_risc tpm i2c_i801 i2c_algo_bit tpm_bios i2c_core evdev intel_agp soundcore snd_page_alloc button processor ext4 mbcache jbd2 crc16 dm_mod sg sr_mod cdrom sd_mod usbhid hid uhci_hcd ahci firewire_ohci libata firewire_core crc_itu_t ehci_hcd r8169 mii scsi_mod thermal usbcore nls_base [last unloaded: scsi_wait_scan]
[    8.818832] Pid: 1064, comm: modprobe Not tainted 2.6.34-rc6-sidux-amd64 #1
[    8.818833] Call Trace:
[    8.818837]  [<ffffffff8104ba83>] ? warn_slowpath_common+0x73/0xb0
[    8.818839]  [<ffffffff8104bb20>] ? warn_slowpath_fmt+0x40/0x50
[    8.818842]  [<ffffffff8114f545>] ? __xlate_proc_name+0xb5/0xd0
[    8.818844]  [<ffffffff8114fb2e>] ? __proc_create+0x7e/0x150
[    8.818846]  [<ffffffff811504e7>] ? proc_mkdir_mode+0x27/0x60
[    8.818849]  [<ffffffff8109fb55>] ? register_handler_proc+0x115/0x130
[    8.818852]  [<ffffffff8109d4c1>] ? __setup_irq+0x1d1/0x330
[    8.818855]  [<ffffffffa03bc160>] ? flexcop_pci_isr+0x0/0x190 [b2c2_flexcop_pci]
[    8.818858]  [<ffffffff8109d735>] ? request_threaded_irq+0x115/0x1b0
[    8.818860]  [<ffffffffa03bc495>] ? flexcop_pci_probe+0x1a5/0x330 [b2c2_flexcop_pci]
[    8.818864]  [<ffffffff811ceef2>] ? local_pci_probe+0x12/0x20
[    8.818867]  [<ffffffff811d02ca>] ? pci_device_probe+0x10a/0x130
[    8.818870]  [<ffffffff8125cdda>] ? driver_sysfs_add+0x5a/0x80
[    8.818872]  [<ffffffff8125cf03>] ? driver_probe_device+0x93/0x190
[    8.818874]  [<ffffffff8125d093>] ? __driver_attach+0x93/0xa0
[    8.818876]  [<ffffffff8125d000>] ? __driver_attach+0x0/0xa0
[    8.818878]  [<ffffffff8125c638>] ? bus_for_each_dev+0x58/0x80
[    8.818880]  [<ffffffff8125be70>] ? bus_add_driver+0xb0/0x250
[    8.818882]  [<ffffffff8125d38a>] ? driver_register+0x6a/0x130
[    8.818884]  [<ffffffff811d056c>] ? __pci_register_driver+0x4c/0xc0
[    8.818887]  [<ffffffffa03bf000>] ? flexcop_pci_module_init+0x0/0x20 [b2c2_flexcop_pci]
[    8.818890]  [<ffffffff81002044>] ? do_one_initcall+0x34/0x1a0
[    8.818893]  [<ffffffff8107d15f>] ? sys_init_module+0xdf/0x260
[    8.818896]  [<ffffffff81009f42>] ? system_call_fastpath+0x16/0x1b
[    8.818897] ---[ end trace 46b5c98323696f39 ]---
[    8.822389] DVB: registering new adapter (FlexCop Digital TV device)
[    8.823874] b2c2-flexcop: MAC address = 00:d0:d7:0c:83:d6

Regards
	Stefan Lippers-Hollmann

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

[Rafael J. Wysocki]

On Wednesday 05 May 2010, Stefan Lippers-Hollmann wrote:
> Hi
> 
> On Wednesday 05 May 2010, Rafael J. Wysocki wrote:
> > This message has been generated automatically as a part of a summary report
> > of recent regressions.
> > 
> > The following bug entry is on the current list of known regressions
> > from 2.6.33.  Please verify if it still should be listed and let the tracking team
> > know (either way).
> > 
> > 
> > Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=15589
> > Subject		: 2.6.34-rc1: Badness at fs/proc/generic.c:316
> > Submitter	: Christian Kujau <lists@nerdbynature.de>
> > Date		: 2010-03-13 23:53 (53 days old)
> > Message-ID	: <alpine.DEB.2.01.1003131544340.5493@bogon.housecafe.de>
> > References	: http://marc.info/?l=linux-kernel&m=126852442903680&w=2
> 
> Still valid for b2c2_flexcop_pci in 2.6.34-rc6-git2:
> 
> [    8.736930] Linux video capture interface: v2.00
> [    8.809720] b2c2-flexcop: B2C2 FlexcopII/II(b)/III digital TV receiver chip loaded successfully
> [    8.818680] flexcop-pci: will use the HW PID filter.
> [    8.818685] flexcop-pci: card revision 2
> [    8.818694] b2c2_flexcop_pci 0000:06:01.0: PCI INT A -> GSI 19 (level, low) -> IRQ 19
> [    8.818794] ------------[ cut here ]------------
> [    8.818799] WARNING: at /tmp/buildd/linux-sidux-2.6-2.6.34~rc6-git2/debian/build/source_amd64_none/fs/proc/generic.c:317 __xlate_proc_name+0xb5/0xd0()
> [    8.818801] Hardware name: EP45-DS3
> [    8.818802] name 'Technisat/B2C2 FlexCop II/IIb/III Digital TV PCI Driver'
> [    8.818804] Modules linked in: b2c2_flexcop_pci(+) cx88xx b2c2_flexcop rfkill v4l2_common ir_common videodev drm snd_pcm snd_seq rtc_cmos snd_timer rtc_core snd_seq_device rtc_lib v4l1_compat tveeprom v4l2_compat_ioctl32 ir_core dvb_core snd videobuf_dma_sg cx24123 cx24113 videobuf_core s5h1420 tpm_tis led_class btcx_risc tpm i2c_i801 i2c_algo_bit tpm_bios i2c_core evdev intel_agp soundcore snd_page_alloc button processor ext4 mbcache jbd2 crc16 dm_mod sg sr_mod cdrom sd_mod usbhid hid uhci_hcd ahci firewire_ohci libata firewire_core crc_itu_t ehci_hcd r8169 mii scsi_mod thermal usbcore nls_base [last unloaded: scsi_wait_scan]
> [    8.818832] Pid: 1064, comm: modprobe Not tainted 2.6.34-rc6-sidux-amd64 #1
> [    8.818833] Call Trace:
> [    8.818837]  [<ffffffff8104ba83>] ? warn_slowpath_common+0x73/0xb0
> [    8.818839]  [<ffffffff8104bb20>] ? warn_slowpath_fmt+0x40/0x50
> [    8.818842]  [<ffffffff8114f545>] ? __xlate_proc_name+0xb5/0xd0
> [    8.818844]  [<ffffffff8114fb2e>] ? __proc_create+0x7e/0x150
> [    8.818846]  [<ffffffff811504e7>] ? proc_mkdir_mode+0x27/0x60
> [    8.818849]  [<ffffffff8109fb55>] ? register_handler_proc+0x115/0x130
> [    8.818852]  [<ffffffff8109d4c1>] ? __setup_irq+0x1d1/0x330
> [    8.818855]  [<ffffffffa03bc160>] ? flexcop_pci_isr+0x0/0x190 [b2c2_flexcop_pci]
> [    8.818858]  [<ffffffff8109d735>] ? request_threaded_irq+0x115/0x1b0
> [    8.818860]  [<ffffffffa03bc495>] ? flexcop_pci_probe+0x1a5/0x330 [b2c2_flexcop_pci]
> [    8.818864]  [<ffffffff811ceef2>] ? local_pci_probe+0x12/0x20
> [    8.818867]  [<ffffffff811d02ca>] ? pci_device_probe+0x10a/0x130
> [    8.818870]  [<ffffffff8125cdda>] ? driver_sysfs_add+0x5a/0x80
> [    8.818872]  [<ffffffff8125cf03>] ? driver_probe_device+0x93/0x190
> [    8.818874]  [<ffffffff8125d093>] ? __driver_attach+0x93/0xa0
> [    8.818876]  [<ffffffff8125d000>] ? __driver_attach+0x0/0xa0
> [    8.818878]  [<ffffffff8125c638>] ? bus_for_each_dev+0x58/0x80
> [    8.818880]  [<ffffffff8125be70>] ? bus_add_driver+0xb0/0x250
> [    8.818882]  [<ffffffff8125d38a>] ? driver_register+0x6a/0x130
> [    8.818884]  [<ffffffff811d056c>] ? __pci_register_driver+0x4c/0xc0
> [    8.818887]  [<ffffffffa03bf000>] ? flexcop_pci_module_init+0x0/0x20 [b2c2_flexcop_pci]
> [    8.818890]  [<ffffffff81002044>] ? do_one_initcall+0x34/0x1a0
> [    8.818893]  [<ffffffff8107d15f>] ? sys_init_module+0xdf/0x260
> [    8.818896]  [<ffffffff81009f42>] ? system_call_fastpath+0x16/0x1b
> [    8.818897] ---[ end trace 46b5c98323696f39 ]---
> [    8.822389] DVB: registering new adapter (FlexCop Digital TV device)
> [    8.823874] b2c2-flexcop: MAC address = 00:d0:d7:0c:83:d6

Thanks for the update.

Rafael

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

[Stefan Lippers-Hollmann]

Hi

On Sunday 13 June 2010, Rafael J. Wysocki wrote:
> This message has been generated automatically as a part of a report
> of regressions introduced between 2.6.33 and 2.6.34.
> 
> The following bug entry is on the current list of known regressions
> introduced between 2.6.33 and 2.6.34.  Please verify if it still should
> be listed and let the tracking team know (either way).
> 
> 
> Bug-Entry	: http://bugzilla.kernel.org/show_bug.cgi?id=15589
> Subject		: 2.6.34-rc1: Badness at fs/proc/generic.c:316
> Submitter	: Christian Kujau <lists@nerdbynature.de>
> Date		: 2010-03-13 23:53 (93 days old)
> Message-ID	: <<alpine.DEB.2.01.1003131544340.5493@bogon.housecafe.de>>
> References	: http://marc.info/?l=linux-kernel&m=126852442903680&w=2
> Handled-By	: Michael Ellerman <michael@ellerman.id.au>
> Patch		: http://patchwork.ozlabs.org/patch/52978/

Still existing in 2.6.34 and 2.6.35 HEAD, however a patch fixing the issue 
for b2c2-flexcop/ flexcop-pci has been posted last week:
	From:		Jindřich Makovička <makovick@gmail.com>
	Subject:		[PATCH] DVB flexcop-pci: sanitize driver name to avoid warning on load
	Date:		Mon, 7 Jun 2010 14:51:30 +0200
	Message-ID:	<AANLkTikNcCtUn9SQwKu2b3IE6NiAwAhciHsm1HVH4EJh@mail.gmail.com>
	URL:			http://lkml.indiana.edu/hypermail/linux/kernel/1006.0/00137.html

Regards
	Stefan Lippers-Hollmann

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

[Christian Kujau]

On Sun, 13 Jun 2010 at 17:22, Stefan Lippers-Hollmann wrote:
> Still existing in 2.6.34 and 2.6.35 HEAD, however a patch fixing the issue 
> for b2c2-flexcop/ flexcop-pci has been posted last week:

So, now we have two patches for slightly different issues?

* http://lkml.indiana.edu/hypermail/linux/kernel/1006.0/00137.html
  ...fixes the flexcop-pci.c driver.

* http://patchwork.ozlabs.org/patch/52978/
  ...fixes "some bogus firmwares include properties with "/" in their
  name". I'm not sure if this would make the flexcop-pci.c badness go 
  away too. 

Anyway, both patches are not upstream yet, but Michael mentioned that 
Grant Likely or Ben might push it eventually.

Thanks,
Christian.
-- 
BOFH excuse #363:

Out of cards on drive D:

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

[Grant Likely]

On Sun, Jun 13, 2010 at 12:10 PM, Christian Kujau <lists@nerdbynature.de> wrote:
> On Sun, 13 Jun 2010 at 17:22, Stefan Lippers-Hollmann wrote:
>> Still existing in 2.6.34 and 2.6.35 HEAD, however a patch fixing the issue
>> for b2c2-flexcop/ flexcop-pci has been posted last week:
>
> So, now we have two patches for slightly different issues?
>
> * http://lkml.indiana.edu/hypermail/linux/kernel/1006.0/00137.html
>  ...fixes the flexcop-pci.c driver.
>
> * http://patchwork.ozlabs.org/patch/52978/
>  ...fixes "some bogus firmwares include properties with "/" in their
>  name". I'm not sure if this would make the flexcop-pci.c badness go
>  away too.
>
> Anyway, both patches are not upstream yet, but Michael mentioned that
> Grant Likely or Ben might push it eventually.

On brief review, they look like completely different issues.  I doubt
the second patch will fix the flexcop-pci issue.  I'll pick up the
device tree patch, but the flexcop-pci patch should go in by the
v4l/dvb tree.

g.

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

[Alexey Dobriyan]

On Sun, Jun 13, 2010 at 01:57:40PM -0600, Grant Likely wrote:
> On brief review, they look like completely different issues.  I doubt
> the second patch will fix the flexcop-pci issue.

It will, see how name wht slashes propagated by request_irq()

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

[Jindrich Makovicka]

On Mon, 14 Jun 2010 09:39:48 +0300
Alexey Dobriyan <adobriyan@gmail.com>
wrote:

> On Sun, Jun 13, 2010 at 01:57:40PM -0600, Grant Likely wrote:
> > On brief review, they look like completely different issues.  I
> > doubt the second patch will fix the flexcop-pci issue.
> 
> It will, see how name wht slashes propagated by request_irq()

Yes, the latter patch dodges the issue with flexcop driver by simply
skipping the directory creation, but both patches should be applied IMO.
The former to fix the flexcop driver because we can trivially fix it,
the latter to solve problems with any generic bogus firmware.

-- 
Jindrich Makovicka

Re: [Bug #15589] 2.6.34-rc1: Badness at fs/proc/generic.c:316

[Grant Likely]

On Mon, Jun 14, 2010 at 12:39 AM, Alexey Dobriyan <adobriyan@gmail.com> wrote:
> On Sun, Jun 13, 2010 at 01:57:40PM -0600, Grant Likely wrote:
>> On brief review, they look like completely different issues.  I doubt
>> the second patch will fix the flexcop-pci issue.
>
> It will, see how name wht slashes propagated by request_irq()

I think we've crossed wires.  By second patch I mean the patch that
changes OF code.  That change has absolutely no bearing on the
flexcop-pci driver.  The patch to the flexcop-pci driver looks correct
to me, but it is completely unrelated to the OF badness.

g.