From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17493 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755214Ab0FUMeq (ORCPT ); Mon, 21 Jun 2010 08:34:46 -0400 Date: Mon, 21 Jun 2010 09:34:36 -0300 From: Mauro Carvalho Chehab To: "Justin P. Mattock" Cc: reiserfs-devel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Subject: Re: [PATCH 8/8 v2]tuners:tuner-simple Fix warning: variable 'tun' set but not used Message-ID: <20100621093436.376b819a@pedra> In-Reply-To: <1276580914-21883-1-git-send-email-justinmattock@gmail.com> References: <1276580914-21883-1-git-send-email-justinmattock@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-media-owner@vger.kernel.org List-ID: Em Mon, 14 Jun 2010 22:48:34 -0700 "Justin P. Mattock" escreveu: > Resend due to a whitespace issue I created by mistake. > The below patch fixes a warning message create by gcc 4.6.0 It seems OK for me, but you shouldn't be sending it to be applied at reiserfs-devel ML. Instead, it should be sent to linux-media ML, and applied via my tree. > > CC [M] drivers/media/common/tuners/tuner-simple.o > drivers/media/common/tuners/tuner-simple.c: In function 'simple_set_tv_freq': > drivers/media/common/tuners/tuner-simple.c:548:20: warning: variable 'tun' set but not used > > Signed-off-by: Justin P. Mattock > Reviewed-By: Mauro Carvalho Chehab > > --- > drivers/media/common/tuners/tuner-simple.c | 3 --- > 1 files changed, 0 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/common/tuners/tuner-simple.c b/drivers/media/common/tuners/tuner-simple.c > index 8abbcc5..84900fa 100644 > --- a/drivers/media/common/tuners/tuner-simple.c > +++ b/drivers/media/common/tuners/tuner-simple.c > @@ -545,14 +545,11 @@ static int simple_set_tv_freq(struct dvb_frontend *fe, > struct tuner_simple_priv *priv = fe->tuner_priv; > u8 config, cb; > u16 div; > - struct tunertype *tun; > u8 buffer[4]; > int rc, IFPCoff, i; > enum param_type desired_type; > struct tuner_params *t_params; > > - tun = priv->tun; > - > /* IFPCoff = Video Intermediate Frequency - Vif: > 940 =16*58.75 NTSC/J (Japan) > 732 =16*45.75 M/N STD -- Cheers, Mauro