From: Jarod Wilson <jarod@redhat.com>
To: linux-media@vger.kernel.org
Cc: linux-input@vger.kernel.org, kmcmartin@redhat.com
Subject: [PATCH] input: fix uninitialized old_keycode oops in input_set_keycode
Date: Mon, 19 Jul 2010 15:59:12 -0400 [thread overview]
Message-ID: <20100719195912.GC31837@redhat.com> (raw)
Patch as suggested by Kyle McMartin, in response to Red Hat bugzilla
615707, filed against a rawhide kernel carrying ir-core enabling patches
from the linuxtv staging/other tree. Fix is based on the similar logic in
input_set_keycode_big, and is confirmed by the bz reporter.
CC: Kyle McMartin <kmcmartin@redhat.com>
Signed-off-by: Jarod Wilson <jarod@redhat.com>
---
drivers/input/input.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/input/input.c b/drivers/input/input.c
index ce5d90d..0c71977 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -900,6 +900,7 @@ int input_set_keycode(struct input_dev *dev,
if (retval)
goto out;
+ old_keycode = kt_entry.keycode;
kt_entry.keycode = keycode;
retval = dev->setkeycodebig(dev, &kt_entry);
--
1.7.1.1
--
Jarod Wilson
jarod@redhat.com
reply other threads:[~2010-07-19 20:08 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100719195912.GC31837@redhat.com \
--to=jarod@redhat.com \
--cc=kmcmartin@redhat.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox