Re: [patch -next] V4L: ivtv: remove unneeded NULL checks

[Dan Carpenter <error27@gmail.com>]

On Fri, Jul 23, 2010 at 07:46:47AM -0400, Andy Walls wrote:
> On Fri, 2010-07-23 at 12:12 +0200, Dan Carpenter wrote:
> > In ivtvfb_callback_cleanup() we dereference "itv" before checking that
> > it's NULL.  "itv" is assigned with container_of() which basically never
> > returns a NULL pointer so the check is pointless.  I removed it, along
> > with a similar check in ivtvfb_callback_init().
> > 
> > I considered adding a check for v4l2_dev, but I looked at the code and I
> > don't think that can be NULL either.
> > 
> > Signed-off-by: Dan Carpenter <error27@gmail.com>
> 
> Hi Dan,
> 
> Thanks, but Jiri Slaby already caught this one:
> 
> https://patchwork.kernel.org/patch/112725/
> 
> I'm going to let Mauro pick up Jiri's patch out of patchwork.
> 

Wow.  It's remarkable how similar they are even down to the change log.

regards,
dan carpenter