From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17750 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757390Ab0G2PhM (ORCPT ); Thu, 29 Jul 2010 11:37:12 -0400 Date: Thu, 29 Jul 2010 11:26:15 -0400 From: Jarod Wilson To: Maxim Levitsky Cc: lirc-list@lists.sourceforge.net, Jarod Wilson , linux-input@vger.kernel.org, linux-media@vger.kernel.org, Mauro Carvalho Chehab , Christoph Bartelmus Subject: Re: [PATCH 0/9 v2] IR: few fixes, additions and ENE driver Message-ID: <20100729152615.GA7507@redhat.com> References: <1280360452-8852-1-git-send-email-maximlevitsky@gmail.com> <20100729035213.GA11543@redhat.com> <1280417428.29938.62.camel@maxim-laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1280417428.29938.62.camel@maxim-laptop> Sender: linux-media-owner@vger.kernel.org List-ID: On Thu, Jul 29, 2010 at 06:30:28PM +0300, Maxim Levitsky wrote: > On Wed, 2010-07-28 at 23:52 -0400, Jarod Wilson wrote: > > On Thu, Jul 29, 2010 at 02:40:43AM +0300, Maxim Levitsky wrote: > > > Hi, > > > This is second version of the patchset. > > > Hopefully, I didn't forget to address all comments. > > > > > > In addition to comments, I changed helper function that processes samples > > > so it sends last space as soon as timeout is reached. > > > This breaks somewhat lirc, because now it gets 2 spaces in row. > > > However, if it uses timeout reports (which are now fully supported) > > > it will get such report in middle. > > > > > > Note that I send timeout report with zero value. > > > I don't think that this value is importaint. > > > > I just patched the entire series into a branch here and tested, no > > regressions with an mceusb transceiver with in-kernel decode, lirc decode > > or lirc tx. Only issue I had (which I neglected to mention earlier) was > > some pedantic issues w/whitespace. Here's the tree I built and tested: > > > > http://git.wilsonet.com/linux-2.6-ir-wip.git/?a=shortlog;h=refs/heads/maxim > > > > 7486d6ae3 addresses all the whitespace/formatting issues I had. Could > > either merge that into your patches, or I can just send it along as an > > additional patch after the fact. In either case, for 1-7 v2: > About whitespace, I usually fix what checkpacth.pl tells me. > Nothing beyond that :-) Yeah, I don't think any of them violate checkpatch.pl's rules, they were more for consistency with the rest of the code being patched. -- Jarod Wilson jarod@redhat.com