From: Michael Grzeschik <m.grzeschik@pengutronix.de>
To: linux-media@vger.kernel.org
Cc: baruch@tkos.co.il, g.liakhovetski@gmx.de, s.hauer@pengutronix.de
Subject: [PATCH v2] mx2_camera: remove emma limitation for RGB565
Date: Mon, 9 Aug 2010 16:22:27 +0200 [thread overview]
Message-ID: <20100809142227.GA32168@pengutronix.de> (raw)
In-Reply-To: <Pine.LNX.4.64.1008052112440.26127@axis700.grange>
X-Uptime: 16:20:11 up 37 days, 5:31, 61 users, load average: 0.68, 0.32,
0.30
In the current source status the emma has no limitation for any PIXFMT
since the data is parsed raw and unprocessed into the memory.
Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
---
v1 -> v2
Changed Comment in emma_buf_init as recommended
drivers/media/video/mx2_camera.c | 15 +++++----------
1 files changed, 5 insertions(+), 10 deletions(-)
diff --git a/drivers/media/video/mx2_camera.c b/drivers/media/video/mx2_camera.c
index e859c7f..ccd121f 100644
--- a/drivers/media/video/mx2_camera.c
+++ b/drivers/media/video/mx2_camera.c
@@ -712,8 +712,11 @@ static void mx27_camera_emma_buf_init(struct soc_camera_device *icd,
/*
* We only use the EMMA engine to get rid of the broken
* DMA Engine. No color space consversion at the moment.
- * We adjust incoming and outgoing pixelformat to rgb16
- * and adjust the bytesperline accordingly.
+ * We set the incomming and outgoing pixelformat to an
+ * 16 Bit wide format and adjust the bytesperline
+ * accordingly. With this configuration the inputdata
+ * will not be changed by the emma and could be any type
+ * of 16 Bit Pixelformat.
*/
writel(PRP_CNTL_CH1EN |
PRP_CNTL_CSIEN |
@@ -897,10 +900,6 @@ static int mx2_camera_set_fmt(struct soc_camera_device *icd,
return -EINVAL;
}
- /* eMMA can only do RGB565 */
- if (mx27_camera_emma(pcdev) && pix->pixelformat != V4L2_PIX_FMT_RGB565)
- return -EINVAL;
-
mf.width = pix->width;
mf.height = pix->height;
mf.field = pix->field;
@@ -944,10 +943,6 @@ static int mx2_camera_try_fmt(struct soc_camera_device *icd,
/* FIXME: implement MX27 limits */
- /* eMMA can only do RGB565 */
- if (mx27_camera_emma(pcdev) && pixfmt != V4L2_PIX_FMT_RGB565)
- return -EINVAL;
-
/* limit to MX25 hardware capabilities */
if (cpu_is_mx25()) {
if (xlate->host_fmt->bits_per_sample <= 8)
--
1.7.1
next prev parent reply other threads:[~2010-08-09 14:22 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-03 9:37 [PATCH 0/5] mx2_camera changes and corrections Michael Grzeschik
2010-08-03 9:37 ` [PATCH 1/5] mx2_camera: change to register and probe Michael Grzeschik
2010-08-03 18:22 ` Guennadi Liakhovetski
2010-08-03 19:57 ` Michael Grzeschik
2010-08-03 23:01 ` Guennadi Liakhovetski
2010-08-04 7:09 ` Sascha Hauer
2010-08-04 8:24 ` Guennadi Liakhovetski
2010-08-04 8:53 ` Michael Grzeschik
2010-08-04 9:48 ` Guennadi Liakhovetski
2010-08-05 20:17 ` Guennadi Liakhovetski
2010-08-10 10:25 ` Michael Grzeschik
2010-08-10 19:08 ` Guennadi Liakhovetski
2010-08-11 7:13 ` Michael Grzeschik
2010-08-03 9:37 ` [PATCH 2/5] mx2_camera: remove emma limitation for RGB565 Michael Grzeschik
2010-08-04 9:55 ` Guennadi Liakhovetski
2010-08-04 10:27 ` Michael Grzeschik
2010-08-05 19:25 ` Guennadi Liakhovetski
2010-08-09 14:22 ` Michael Grzeschik [this message]
2010-08-09 14:57 ` [PATCH v2][RESEND] " Michael Grzeschik
2010-08-03 9:37 ` [PATCH 3/5] mx2_camera: fix for list bufnum in frame_done_emma Michael Grzeschik
2010-08-03 9:37 ` [PATCH 4/5] mx2_camera: add rising edge for pixclock Michael Grzeschik
2010-08-03 9:37 ` [PATCH 5/5] mx2_camera: add informative camera clock frequency printout Michael Grzeschik
2010-08-05 20:30 ` Guennadi Liakhovetski
2010-08-05 20:54 ` Michael Grzeschik
2010-08-27 9:46 ` Guennadi Liakhovetski
2010-08-27 12:39 ` [PATCH v2] " Michael Grzeschik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100809142227.GA32168@pengutronix.de \
--to=m.grzeschik@pengutronix.de \
--cc=baruch@tkos.co.il \
--cc=g.liakhovetski@gmx.de \
--cc=linux-media@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox