* 2.6.35 and current v4l-dvb - error: implicit declaration of function 'usb_buffer_free' @ 2010-08-11 22:29 Goga777 2010-08-13 2:19 ` Douglas Schilling Landgraf 0 siblings, 1 reply; 7+ messages in thread From: Goga777 @ 2010-08-11 22:29 UTC (permalink / raw) To: linux-media Hi I can't compile current v4l-dvb with new 2.6.35 kernel arvdr:/usr/src/v4l-dvb# make make -C /usr/src/v4l-dvb/v4l make[1]: Entering directory `/usr/src/v4l-dvb/v4l' creating symbolic links... make -C firmware prep make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' make -C firmware make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' make[2]: Nothing to be done for `default'. make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' Kernel build directory is /lib/modules/2.6.35-tux/build make -C /lib/modules/2.6.35-tux/build SUBDIRS=/usr/src/v4l-dvb/v4l modules make[2]: Entering directory `/usr/src/linux-2.6.35' CC [M] /usr/src/v4l-dvb/v4l/au0828-video.o /usr/src/v4l-dvb/v4l/au0828-video.c: In function 'au0828_uninit_isoc': /usr/src/v4l-dvb/v4l/au0828-video.c:185: error: implicit declaration of function 'usb_buffer_free' /usr/src/v4l-dvb/v4l/au0828-video.c: In function 'au0828_init_isoc': /usr/src/v4l-dvb/v4l/au0828-video.c:255: error: implicit declaration of function 'usb_buffer_alloc' /usr/src/v4l-dvb/v4l/au0828-video.c:256: warning: assignment makes pointer from integer without a cast make[3]: *** [/usr/src/v4l-dvb/v4l/au0828-video.o] Ошибка 1 make[2]: *** [_module_/usr/src/v4l-dvb/v4l] Error 2 make[2]: Leaving directory `/usr/src/linux-2.6.35' make[1]: *** [default] Ошибка 2 make[1]: Leaving directory `/usr/src/v4l-dvb/v4l' make: *** [all] Ошибка 2 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.6.35 and current v4l-dvb - error: implicit declaration of function 'usb_buffer_free' 2010-08-11 22:29 2.6.35 and current v4l-dvb - error: implicit declaration of function 'usb_buffer_free' Goga777 @ 2010-08-13 2:19 ` Douglas Schilling Landgraf 2010-08-13 8:37 ` Goga777 2010-08-13 10:38 ` Igor M. Liplianin 0 siblings, 2 replies; 7+ messages in thread From: Douglas Schilling Landgraf @ 2010-08-13 2:19 UTC (permalink / raw) To: Goga777; +Cc: linux-media Hello, 2010/8/11 Goga777 <goga777@bk.ru>: > Hi > > I can't compile current v4l-dvb with new 2.6.35 kernel > > arvdr:/usr/src/v4l-dvb# make > make -C /usr/src/v4l-dvb/v4l > make[1]: Entering directory `/usr/src/v4l-dvb/v4l' > creating symbolic links... > make -C firmware prep > make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' > make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' > make -C firmware > make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' > make[2]: Nothing to be done for `default'. > make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' > Kernel build directory is /lib/modules/2.6.35-tux/build > make -C /lib/modules/2.6.35-tux/build SUBDIRS=/usr/src/v4l-dvb/v4l modules > make[2]: Entering directory `/usr/src/linux-2.6.35' > CC [M] /usr/src/v4l-dvb/v4l/au0828-video.o > /usr/src/v4l-dvb/v4l/au0828-video.c: In function 'au0828_uninit_isoc': > /usr/src/v4l-dvb/v4l/au0828-video.c:185: error: implicit declaration of function 'usb_buffer_free' > /usr/src/v4l-dvb/v4l/au0828-video.c: In function 'au0828_init_isoc': > /usr/src/v4l-dvb/v4l/au0828-video.c:255: error: implicit declaration of function 'usb_buffer_alloc' > /usr/src/v4l-dvb/v4l/au0828-video.c:256: warning: assignment makes pointer from integer without a cast > make[3]: *** [/usr/src/v4l-dvb/v4l/au0828-video.o] Ошибка 1 > make[2]: *** [_module_/usr/src/v4l-dvb/v4l] Error 2 > make[2]: Leaving directory `/usr/src/linux-2.6.35' > make[1]: *** [default] Ошибка 2 > make[1]: Leaving directory `/usr/src/v4l-dvb/v4l' > make: *** [all] Ошибка 2 > Both functions were renamed in upstream, backport created and commited, please try again. Cheers Douglas ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.6.35 and current v4l-dvb - error: implicit declaration of function 'usb_buffer_free' 2010-08-13 2:19 ` Douglas Schilling Landgraf @ 2010-08-13 8:37 ` Goga777 2010-08-13 9:44 ` Goga777 2010-08-13 10:38 ` Igor M. Liplianin 1 sibling, 1 reply; 7+ messages in thread From: Goga777 @ 2010-08-13 8:37 UTC (permalink / raw) To: linux-media > Both functions were renamed in upstream, backport created and > commited, please try again. yes, I don't have more such errors, but still have other one which I reported early CC [M] /usr/src/v4l-dvb/v4l/dvb_net.o /usr/src/v4l-dvb/v4l/dvb_net.c:1190: warning: 'struct dev_mc_list' declared inside parameter list /usr/src/v4l-dvb/v4l/dvb_net.c:1190: warning: its scope is only this definition or declaration, which is probably not what you want /usr/src/v4l-dvb/v4l/dvb_net.c: In function 'dvb_set_mc_filter': /usr/src/v4l-dvb/v4l/dvb_net.c:1197: error: dereferencing pointer to incomplete type /usr/src/v4l-dvb/v4l/dvb_net.c:1197: error: dereferencing pointer to incomplete type /usr/src/v4l-dvb/v4l/dvb_net.c: In function 'wq_set_multicast_list': /usr/src/v4l-dvb/v4l/dvb_net.c:1247: error: 'struct net_device' has no member named 'mc_list' /usr/src/v4l-dvb/v4l/dvb_net.c:1249: error: dereferencing pointer to incomplete type /usr/src/v4l-dvb/v4l/dvb_net.c:1249: warning: left-hand operand of comma expression has no effect /usr/src/v4l-dvb/v4l/dvb_net.c:1249: warning: value computed is not used /usr/src/v4l-dvb/v4l/dvb_net.c:1250: warning: passing argument 2 of 'dvb_set_mc_filter' from incompatible pointer type /usr/src/v4l-dvb/v4l/dvb_net.c:1190: note: expected 'struct dev_mc_list *' but argument is of type 'struct dev_mc_list *' make[3]: *** [/usr/src/v4l-dvb/v4l/dvb_net.o] Ошибка 1 make[2]: *** [_module_/usr/src/v4l-dvb/v4l] Error 2 make[2]: Leaving directory `/usr/src/linux-2.6.35' make[1]: *** [default] Ошибка 2 make[1]: Leaving directory `/usr/src/v4l-dvb/v4l' make: *** [all] Ошибка 2 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.6.35 and current v4l-dvb - error: implicit declaration of function 'usb_buffer_free' 2010-08-13 8:37 ` Goga777 @ 2010-08-13 9:44 ` Goga777 0 siblings, 0 replies; 7+ messages in thread From: Goga777 @ 2010-08-13 9:44 UTC (permalink / raw) To: linux-media > > Both functions were renamed in upstream, backport created and > > commited, please try again. yes, I don't have more such errors, but still have other one which I reported early > CC [M] /usr/src/v4l-dvb/v4l/dvb_net.o > /usr/src/v4l-dvb/v4l/dvb_net.c:1190: warning: 'struct dev_mc_list' declared inside parameter list > /usr/src/v4l-dvb/v4l/dvb_net.c:1190: warning: its scope is only this definition or declaration, which is > probably not what you want /usr/src/v4l-dvb/v4l/dvb_net.c: In function 'dvb_set_mc_filter': > /usr/src/v4l-dvb/v4l/dvb_net.c:1197: error: dereferencing pointer to incomplete type > /usr/src/v4l-dvb/v4l/dvb_net.c:1197: error: dereferencing pointer to incomplete type > /usr/src/v4l-dvb/v4l/dvb_net.c: In function 'wq_set_multicast_list': > /usr/src/v4l-dvb/v4l/dvb_net.c:1247: error: 'struct net_device' has no member named 'mc_list' > /usr/src/v4l-dvb/v4l/dvb_net.c:1249: error: dereferencing pointer to incomplete type > /usr/src/v4l-dvb/v4l/dvb_net.c:1249: warning: left-hand operand of comma expression has no effect > /usr/src/v4l-dvb/v4l/dvb_net.c:1249: warning: value computed is not used > /usr/src/v4l-dvb/v4l/dvb_net.c:1250: warning: passing argument 2 of 'dvb_set_mc_filter' from incompatible > pointer type /usr/src/v4l-dvb/v4l/dvb_net.c:1190: note: expected 'struct dev_mc_list *' but argument is > of type 'struct dev_mc_list *' make[3]: *** [/usr/src/v4l-dvb/v4l/dvb_net.o] Ошибка 1 > make[2]: *** [_module_/usr/src/v4l-dvb/v4l] Error 2 > make[2]: Leaving directory `/usr/src/linux-2.6.35' > make[1]: *** [default] Ошибка 2 > make[1]: Leaving directory `/usr/src/v4l-dvb/v4l' > make: *** [all] Ошибка 2 ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.6.35 and current v4l-dvb - error: implicit declaration of function 'usb_buffer_free' 2010-08-13 2:19 ` Douglas Schilling Landgraf 2010-08-13 8:37 ` Goga777 @ 2010-08-13 10:38 ` Igor M. Liplianin 2010-08-13 12:53 ` Douglas Schilling Landgraf 1 sibling, 1 reply; 7+ messages in thread From: Igor M. Liplianin @ 2010-08-13 10:38 UTC (permalink / raw) To: Douglas Schilling Landgraf, Goga777, linux-media В сообщении от 13 августа 2010 05:19:49 автор Douglas Schilling Landgraf написал: > Hello, > > 2010/8/11 Goga777 <goga777@bk.ru>: > > Hi > > > > I can't compile current v4l-dvb with new 2.6.35 kernel > > > > arvdr:/usr/src/v4l-dvb# make > > make -C /usr/src/v4l-dvb/v4l > > make[1]: Entering directory `/usr/src/v4l-dvb/v4l' > > creating symbolic links... > > make -C firmware prep > > make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' > > make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' > > make -C firmware > > make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' > > make[2]: Nothing to be done for `default'. > > make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' > > Kernel build directory is /lib/modules/2.6.35-tux/build > > make -C /lib/modules/2.6.35-tux/build SUBDIRS=/usr/src/v4l-dvb/v4l > > modules make[2]: Entering directory `/usr/src/linux-2.6.35' > > CC [M] /usr/src/v4l-dvb/v4l/au0828-video.o > > /usr/src/v4l-dvb/v4l/au0828-video.c: In function 'au0828_uninit_isoc': > > /usr/src/v4l-dvb/v4l/au0828-video.c:185: error: implicit declaration of > > function 'usb_buffer_free' /usr/src/v4l-dvb/v4l/au0828-video.c: In > > function 'au0828_init_isoc': /usr/src/v4l-dvb/v4l/au0828-video.c:255: > > error: implicit declaration of function 'usb_buffer_alloc' > > /usr/src/v4l-dvb/v4l/au0828-video.c:256: warning: assignment makes > > pointer from integer without a cast make[3]: *** > > [/usr/src/v4l-dvb/v4l/au0828-video.o] Ошибка 1 > > make[2]: *** [_module_/usr/src/v4l-dvb/v4l] Error 2 > > make[2]: Leaving directory `/usr/src/linux-2.6.35' > > make[1]: *** [default] Ошибка 2 > > make[1]: Leaving directory `/usr/src/v4l-dvb/v4l' > > make: *** [all] Ошибка 2 > > Both functions were renamed in upstream, backport created and > commited, please try again. > > Cheers > Douglas > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html Is it better other way round, to rename all appearances of functions and define a macro? Like this: #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,35) #define usb_alloc_coherent(a, b, c, d) usb_buffer_alloc(a, b, c, d) #define usb_free_coherent(a, b, c, d) usb_buffer_free(a, b, c, d) #endif In the end it will be more similar in code to the last kernel :) -- Igor M. Liplianin Microsoft Windows Free Zone - Linux used for all Computing Tasks ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.6.35 and current v4l-dvb - error: implicit declaration of function 'usb_buffer_free' 2010-08-13 10:38 ` Igor M. Liplianin @ 2010-08-13 12:53 ` Douglas Schilling Landgraf 2010-08-13 14:08 ` Mauro Carvalho Chehab 0 siblings, 1 reply; 7+ messages in thread From: Douglas Schilling Landgraf @ 2010-08-13 12:53 UTC (permalink / raw) To: Igor M. Liplianin; +Cc: Goga777, linux-media Hello, 2010/8/13 Igor M. Liplianin <liplianin@me.by>: > В сообщении от 13 августа 2010 05:19:49 автор Douglas Schilling Landgraf написал: >> Hello, >> >> 2010/8/11 Goga777 <goga777@bk.ru>: >> > Hi >> > >> > I can't compile current v4l-dvb with new 2.6.35 kernel >> > >> > arvdr:/usr/src/v4l-dvb# make >> > make -C /usr/src/v4l-dvb/v4l >> > make[1]: Entering directory `/usr/src/v4l-dvb/v4l' >> > creating symbolic links... >> > make -C firmware prep >> > make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' >> > make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' >> > make -C firmware >> > make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' >> > make[2]: Nothing to be done for `default'. >> > make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' >> > Kernel build directory is /lib/modules/2.6.35-tux/build >> > make -C /lib/modules/2.6.35-tux/build SUBDIRS=/usr/src/v4l-dvb/v4l >> > modules make[2]: Entering directory `/usr/src/linux-2.6.35' >> > CC [M] /usr/src/v4l-dvb/v4l/au0828-video.o >> > /usr/src/v4l-dvb/v4l/au0828-video.c: In function 'au0828_uninit_isoc': >> > /usr/src/v4l-dvb/v4l/au0828-video.c:185: error: implicit declaration of >> > function 'usb_buffer_free' /usr/src/v4l-dvb/v4l/au0828-video.c: In >> > function 'au0828_init_isoc': /usr/src/v4l-dvb/v4l/au0828-video.c:255: >> > error: implicit declaration of function 'usb_buffer_alloc' >> > /usr/src/v4l-dvb/v4l/au0828-video.c:256: warning: assignment makes >> > pointer from integer without a cast make[3]: *** >> > [/usr/src/v4l-dvb/v4l/au0828-video.o] Ошибка 1 >> > make[2]: *** [_module_/usr/src/v4l-dvb/v4l] Error 2 >> > make[2]: Leaving directory `/usr/src/linux-2.6.35' >> > make[1]: *** [default] Ошибка 2 >> > make[1]: Leaving directory `/usr/src/v4l-dvb/v4l' >> > make: *** [all] Ошибка 2 >> >> Both functions were renamed in upstream, backport created and >> commited, please try again. >> >> Cheers >> Douglas >> -- >> To unsubscribe from this list: send the line "unsubscribe linux-media" in >> the body of a message to majordomo@vger.kernel.org >> More majordomo info at http://vger.kernel.org/majordomo-info.html > Is it better other way round, to rename all appearances of functions and define a macro? > Like this: > > #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,35) > #define usb_alloc_coherent(a, b, c, d) usb_buffer_alloc(a, b, c, d) > #define usb_free_coherent(a, b, c, d) usb_buffer_free(a, b, c, d) > #endif > > In the end it will be more similar in code to the last kernel :) Yes, agreed but all drivers must be renamed with the new function name first. Otherwise, it will keep breaking. Thanks for looking it. Cheers Douglas ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: 2.6.35 and current v4l-dvb - error: implicit declaration of function 'usb_buffer_free' 2010-08-13 12:53 ` Douglas Schilling Landgraf @ 2010-08-13 14:08 ` Mauro Carvalho Chehab 0 siblings, 0 replies; 7+ messages in thread From: Mauro Carvalho Chehab @ 2010-08-13 14:08 UTC (permalink / raw) To: Douglas Schilling Landgraf; +Cc: Igor M. Liplianin, Goga777, linux-media Em 13-08-2010 09:53, Douglas Schilling Landgraf escreveu: > Hello, > > 2010/8/13 Igor M. Liplianin <liplianin@me.by>: >> В сообщении от 13 августа 2010 05:19:49 автор Douglas Schilling Landgraf написал: >>> Hello, >>> >>> 2010/8/11 Goga777 <goga777@bk.ru>: >>>> Hi >>>> >>>> I can't compile current v4l-dvb with new 2.6.35 kernel >>>> >>>> arvdr:/usr/src/v4l-dvb# make >>>> make -C /usr/src/v4l-dvb/v4l >>>> make[1]: Entering directory `/usr/src/v4l-dvb/v4l' >>>> creating symbolic links... >>>> make -C firmware prep >>>> make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' >>>> make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' >>>> make -C firmware >>>> make[2]: Entering directory `/usr/src/v4l-dvb/v4l/firmware' >>>> make[2]: Nothing to be done for `default'. >>>> make[2]: Leaving directory `/usr/src/v4l-dvb/v4l/firmware' >>>> Kernel build directory is /lib/modules/2.6.35-tux/build >>>> make -C /lib/modules/2.6.35-tux/build SUBDIRS=/usr/src/v4l-dvb/v4l >>>> modules make[2]: Entering directory `/usr/src/linux-2.6.35' >>>> CC [M] /usr/src/v4l-dvb/v4l/au0828-video.o >>>> /usr/src/v4l-dvb/v4l/au0828-video.c: In function 'au0828_uninit_isoc': >>>> /usr/src/v4l-dvb/v4l/au0828-video.c:185: error: implicit declaration of >>>> function 'usb_buffer_free' /usr/src/v4l-dvb/v4l/au0828-video.c: In >>>> function 'au0828_init_isoc': /usr/src/v4l-dvb/v4l/au0828-video.c:255: >>>> error: implicit declaration of function 'usb_buffer_alloc' >>>> /usr/src/v4l-dvb/v4l/au0828-video.c:256: warning: assignment makes >>>> pointer from integer without a cast make[3]: *** >>>> [/usr/src/v4l-dvb/v4l/au0828-video.o] Ошибка 1 >>>> make[2]: *** [_module_/usr/src/v4l-dvb/v4l] Error 2 >>>> make[2]: Leaving directory `/usr/src/linux-2.6.35' >>>> make[1]: *** [default] Ошибка 2 >>>> make[1]: Leaving directory `/usr/src/v4l-dvb/v4l' >>>> make: *** [all] Ошибка 2 >>> >>> Both functions were renamed in upstream, backport created and >>> commited, please try again. >>> >>> Cheers >>> Douglas >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-media" in >>> the body of a message to majordomo@vger.kernel.org >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >> Is it better other way round, to rename all appearances of functions and define a macro? >> Like this: >> >> #if LINUX_VERSION_CODE < KERNEL_VERSION(2,6,35) >> #define usb_alloc_coherent(a, b, c, d) usb_buffer_alloc(a, b, c, d) >> #define usb_free_coherent(a, b, c, d) usb_buffer_free(a, b, c, d) >> #endif >> >> In the end it will be more similar in code to the last kernel :) > > Yes, agreed but all drivers must be renamed with the new function name first. > Otherwise, it will keep breaking. Thanks for looking it. That's the reason why I used to first backport all upstream patches, and then work on a fix. An upstream patchset already did such change. > > Cheers > Douglas > -- > To unsubscribe from this list: send the line "unsubscribe linux-media" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2010-08-13 14:08 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2010-08-11 22:29 2.6.35 and current v4l-dvb - error: implicit declaration of function 'usb_buffer_free' Goga777 2010-08-13 2:19 ` Douglas Schilling Landgraf 2010-08-13 8:37 ` Goga777 2010-08-13 9:44 ` Goga777 2010-08-13 10:38 ` Igor M. Liplianin 2010-08-13 12:53 ` Douglas Schilling Landgraf 2010-08-13 14:08 ` Mauro Carvalho Chehab
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox