From: Anton Blanchard <anton@samba.org>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: "David Härdeman" <david@hardeman.nu>, linux-media@vger.kernel.org
Subject: Re: IR code autorepeat issue?
Date: Tue, 21 Sep 2010 08:55:27 +1000 [thread overview]
Message-ID: <20100920225527.GK25306@kryten> (raw)
In-Reply-To: <4C87BA04.7030908@redhat.com>
Hi,
> > > I'm seeing double IR events on 2.6.36-rc2 and a DViCO FusionHDTV DVB-T
> > > Dual Express.
> >
> > There's one issue on touching on this constant: it is currently just one
> > global timeout value that will be used by all protocols. This timeout
> > should be enough to retrieve and proccess the repeat key event on all
> > protocols, and on all devices, or we'll need to do a per-protocol (and
> > eventually per device) timeout init. From
> > http://www.sbprojects.com/knowledge/ir/ir.htm, we see that NEC prococol
> > uses 110 ms for repeat code, and we need some aditional time to wake up the
> > decoding task. I'd say that anything lower than 150-180ms would risk to not
> > decode repeat events with NEC.
> >
> > I got exactly the same problem when adding RC CORE support at the dib0700
> > driver. At that driver, there's an additional time of sending/receiving
> > URB's from USB. So, we probably need a higher timeout. Even so, I tried to
> > reduce the timeout to 200ms or 150ms (not sure), but it didn't work. So, I
> > ended by just patching the dibcom driver to do dev->rep[REP_DELAY] = 500:
>
> Ok, just sent a patch adding it to rc-core, and removing from dib0700 driver.
Thanks, tested and confirmed to work!
I originally hit this on Ubuntu Maverick. Would you be OK if I submit it for
backport to 2.6.35 stable?
Anton
next prev parent reply other threads:[~2010-09-20 22:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-29 6:40 IR code autorepeat issue? Anton Blanchard
2010-08-29 15:44 ` Mauro Carvalho Chehab
2010-09-08 16:29 ` Mauro Carvalho Chehab
2010-09-20 22:55 ` Anton Blanchard [this message]
2010-09-21 4:44 ` Jarod Wilson
-- strict thread matches above, loose matches on Subject: below --
2010-08-30 1:26 Andy Walls
2010-08-30 12:50 ` Mauro Carvalho Chehab
2010-08-31 13:55 ` David Härdeman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100920225527.GK25306@kryten \
--to=anton@samba.org \
--cc=david@hardeman.nu \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox