Re: [PATCH 09/10] V4L/DVB: tda18271: Add debug message with frequency divisor

Mauro Carvalho Chehab
2010-09-30T19:16:47Z

Em 30-09-2010 16:03, Michael Krufky escreveu:
> On Tue, Sep 28, 2010 at 2:47 PM, Mauro Carvalho Chehab
> <mchehab@redhat.com> wrote:
>> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>>
>> diff --git a/drivers/media/common/tuners/tda18271-common.c b/drivers/media/common/tuners/tda18271-common.c
>> index 195b30e..7ba3ba3 100644
>> --- a/drivers/media/common/tuners/tda18271-common.c
>> +++ b/drivers/media/common/tuners/tda18271-common.c
>> @@ -549,6 +549,13 @@ int tda18271_calc_main_pll(struct dvb_frontend *fe, u32 freq)
>> regs[R_MD1] = 0x7f & (div >> 16);
>> regs[R_MD2] = 0xff & (div >> 8);
>> regs[R_MD3] = 0xff & div;
>> +
>> + if (tda18271_debug & DBG_REG) {
>> + tda_reg("MAIN_DIV_BYTE_1 = 0x%02x\n", 0xff & regs[R_MD1]);
>> + tda_reg("MAIN_DIV_BYTE_2 = 0x%02x\n", 0xff & regs[R_MD2]);
>> + tda_reg("MAIN_DIV_BYTE_3 = 0x%02x\n", 0xff & regs[R_MD3]);
>> + }
>> +
>> fail:
>> return ret;
>> }
>
>
> I would actually prefer NOT to merge this - it is redundant. When
> DBG_REG is enabled, the driver will dump the contents of all
> registers, including MD1, MD2 and MD3. With this patch applied, it
> would dump this data twice. I do not believe this is useful at all.

Ok.

>
> Regards,
>
> Mike Krufky