* [PATCH 1/3] V4L/DVB: videobuf-dma-sg: Fix a warning due to the usage of min(PAGE_SIZE, arg)
@ 2010-10-07 1:56 Mauro Carvalho Chehab
2010-10-07 7:48 ` Laurent Pinchart
0 siblings, 1 reply; 2+ messages in thread
From: Mauro Carvalho Chehab @ 2010-10-07 1:56 UTC (permalink / raw)
Cc: Linux Media Mailing List
drivers/media/video/videobuf-dma-sg.c: In function ‘videobuf_pages_to_sg’:
drivers/media/video/videobuf-dma-sg.c:119: warning: comparison of distinct pointer types lacks a cast
drivers/media/video/videobuf-dma-sg.c:120: warning: comparison of distinct pointer types lacks a cast
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
diff --git a/drivers/media/video/videobuf-dma-sg.c b/drivers/media/video/videobuf-dma-sg.c
index 359f2f3..7153e44 100644
--- a/drivers/media/video/videobuf-dma-sg.c
+++ b/drivers/media/video/videobuf-dma-sg.c
@@ -116,8 +116,8 @@ static struct scatterlist *videobuf_pages_to_sg(struct page **pages,
goto nopage;
if (PageHighMem(pages[i]))
goto highmem;
- sg_set_page(&sglist[i], pages[i], min(PAGE_SIZE, size), 0);
- size -= min(PAGE_SIZE, size);
+ sg_set_page(&sglist[i], pages[i], min((unsigned)PAGE_SIZE, size), 0);
+ size -= min((unsigned)PAGE_SIZE, size);
}
return sglist;
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] V4L/DVB: videobuf-dma-sg: Fix a warning due to the usage of min(PAGE_SIZE, arg)
2010-10-07 1:56 [PATCH 1/3] V4L/DVB: videobuf-dma-sg: Fix a warning due to the usage of min(PAGE_SIZE, arg) Mauro Carvalho Chehab
@ 2010-10-07 7:48 ` Laurent Pinchart
0 siblings, 0 replies; 2+ messages in thread
From: Laurent Pinchart @ 2010-10-07 7:48 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Linux Media Mailing List
Hi Mauro,
On Thursday 07 October 2010 03:56:47 Mauro Carvalho Chehab wrote:
> drivers/media/video/videobuf-dma-sg.c: In function ‘videobuf_pages_to_sg’:
> drivers/media/video/videobuf-dma-sg.c:119: warning: comparison of distinct
> pointer types lacks a cast drivers/media/video/videobuf-dma-sg.c:120:
> warning: comparison of distinct pointer types lacks a cast
>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>
>
> diff --git a/drivers/media/video/videobuf-dma-sg.c
> b/drivers/media/video/videobuf-dma-sg.c index 359f2f3..7153e44 100644
> --- a/drivers/media/video/videobuf-dma-sg.c
> +++ b/drivers/media/video/videobuf-dma-sg.c
> @@ -116,8 +116,8 @@ static struct scatterlist *videobuf_pages_to_sg(struct
> page **pages, goto nopage;
> if (PageHighMem(pages[i]))
> goto highmem;
> - sg_set_page(&sglist[i], pages[i], min(PAGE_SIZE, size), 0);
> - size -= min(PAGE_SIZE, size);
> + sg_set_page(&sglist[i], pages[i], min((unsigned)PAGE_SIZE, size), 0);
> + size -= min((unsigned)PAGE_SIZE, size);
I think min_t(size_t, PAGE_SIZE, size) is the preferred way.
> }
> return sglist;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2010-10-07 7:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-10-07 1:56 [PATCH 1/3] V4L/DVB: videobuf-dma-sg: Fix a warning due to the usage of min(PAGE_SIZE, arg) Mauro Carvalho Chehab
2010-10-07 7:48 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox