gspca, audio and ov534: regression.

gspca, audio and ov534: regression.

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

Hi,

with 2.6.36-rc6 I can't use the ov534 gspca subdriver (with PS3 eye)
anymore, when I try to capture video in dmesg I get:
gspca: no transfer endpoint found

If I revert commit 35680ba I can make video capture work again but I
still don't get the audio device in pulseaudio, it shows up in alsamixer
but if I try to select it, on the console I get:
cannot load mixer controls: Invalid argument

I'll test with latest Jean-François tree, and if it still fails I'll try
to find a solution, but I wanted to report it quickly first, I hope we
fix this before 2.6.36.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: gspca, audio and ov534: regression.

[Jean-Francois Moine]

On Wed, 6 Oct 2010 12:33:21 +0200
Antonio Ospite <ospite@studenti.unina.it> wrote:

> with 2.6.36-rc6 I can't use the ov534 gspca subdriver (with PS3 eye)
> anymore, when I try to capture video in dmesg I get:
> gspca: no transfer endpoint found
> 
> If I revert commit 35680ba I can make video capture work again but I
> still don't get the audio device in pulseaudio, it shows up in
> alsamixer but if I try to select it, on the console I get:
> cannot load mixer controls: Invalid argument
> 
> I'll test with latest Jean-François tree, and if it still fails I'll
> try to find a solution, but I wanted to report it quickly first, I
> hope we fix this before 2.6.36.

Hi Antonio,

I think I see why the commit prevents the webcam to work: as it is
done, the choice of the alternate setting does not work with bulk
transfer. A simple fix could be to also check bulk transfer when
skipping an alt setting in the function get_ep().

About audio stream, I do not see how it can have been broken.

Might you send me the full USB information of your webcam?

Best regards.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

Re: gspca, audio and ov534: regression.

[Antonio Ospite]

[-- Attachment #1.1: Type: text/plain, Size: 2730 bytes --]

On Wed, 6 Oct 2010 13:48:55 +0200
Jean-Francois Moine <moinejf@free.fr> wrote:

> On Wed, 6 Oct 2010 12:33:21 +0200
> Antonio Ospite <ospite@studenti.unina.it> wrote:
> 
> > with 2.6.36-rc6 I can't use the ov534 gspca subdriver (with PS3 eye)
> > anymore, when I try to capture video in dmesg I get:
> > gspca: no transfer endpoint found
> > 
> > If I revert commit 35680ba I can make video capture work again but I
> > still don't get the audio device in pulseaudio, it shows up in
> > alsamixer but if I try to select it, on the console I get:
> > cannot load mixer controls: Invalid argument
> > 
[...]
> 
> I think I see why the commit prevents the webcam to work: as it is
> done, the choice of the alternate setting does not work with bulk
> transfer. A simple fix could be to also check bulk transfer when
> skipping an alt setting in the function get_ep().
>

Thanks, the following change fixes it, was this what you had in mind?

diff --git a/drivers/media/video/gspca/gspca.c b/drivers/media/video/gspca/gspca.c
index b984610..30e0b32 100644
--- a/drivers/media/video/gspca/gspca.c
+++ b/drivers/media/video/gspca/gspca.c
@@ -651,7 +651,7 @@ static struct usb_host_endpoint *get_ep(struct gspca_dev *gspca_dev)
                                   : USB_ENDPOINT_XFER_ISOC;
        i = gspca_dev->alt;                     /* previous alt setting */
        if (gspca_dev->cam.reverse_alts) {
-               if (gspca_dev->audio)
+               if (gspca_dev->audio && !gspca_dev->cam.bulk)
                        i++;
                while (++i < gspca_dev->nbalt) {
                        ep = alt_xfer(&intf->altsetting[i], xfer);
@@ -659,7 +659,7 @@ static struct usb_host_endpoint *get_ep(struct gspca_dev *gspca_dev)
                                break;
                }
        } else {
-               if (gspca_dev->audio)
+               if (gspca_dev->audio && !gspca_dev->cam.bulk)
                        i--;
                while (--i >= 0) {
                        ep = alt_xfer(&intf->altsetting[i], xfer);


> About audio stream, I do not see how it can have been broken.
>

PS3 Eye audio is working with linux-2.6.33.7 it is broken in
linux-2.6.35.7 already, I'll try to further narrow down the interval.
Ah, alsamixer doesn't work even when the device is OK in pulseaudio...

> Might you send me the full USB information of your webcam?
>

You can find lsusb output attached.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #1.2: lsusb_pseye.log --]
[-- Type: application/octet-stream, Size: 6803 bytes --]


Bus 001 Device 004: ID 1415:2000 Nam Tai E&E Products Ltd. or OmniVision Technologies, Inc. Sony Playstation Eye
Device Descriptor:
  bLength                18
  bDescriptorType         1
  bcdUSB               2.00
  bDeviceClass            0 (Defined at Interface level)
  bDeviceSubClass         0 
  bDeviceProtocol         0 
  bMaxPacketSize0        64
  idVendor           0x1415 Nam Tai E&E Products Ltd. or OmniVision Technologies, Inc.
  idProduct          0x2000 Sony Playstation Eye
  bcdDevice            1.00
  iManufacturer           1 OmniVision Technologies, Inc.
  iProduct                2 USB Camera-B4.04.27.1
  iSerial                 0 
  bNumConfigurations      1
  Configuration Descriptor:
    bLength                 9
    bDescriptorType         2
    wTotalLength          142
    bNumInterfaces          3
    bConfigurationValue     1
    iConfiguration          0 
    bmAttributes         0x80
      (Bus Powered)
    MaxPower              500mA
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        0
      bAlternateSetting       0
      bNumEndpoints           3
      bInterfaceClass       255 Vendor Specific Class
      bInterfaceSubClass      0 
      bInterfaceProtocol      0 
      iInterface              0 
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x81  EP 1 IN
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0200  1x 512 bytes
        bInterval               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x02  EP 2 OUT
        bmAttributes            2
          Transfer Type            Bulk
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0200  1x 512 bytes
        bInterval               0
      Endpoint Descriptor:
        bLength                 7
        bDescriptorType         5
        bEndpointAddress     0x83  EP 3 IN
        bmAttributes            3
          Transfer Type            Interrupt
          Synch Type               None
          Usage Type               Data
        wMaxPacketSize     0x0040  1x 64 bytes
        bInterval              10
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        1
      bAlternateSetting       0
      bNumEndpoints           0
      bInterfaceClass         1 Audio
      bInterfaceSubClass      1 Control Device
      bInterfaceProtocol      0 
      iInterface              0 
      AudioControl Interface Descriptor:
        bLength                 9
        bDescriptorType        36
        bDescriptorSubtype      1 (HEADER)
        bcdADC               1.00
        wTotalLength           42
        bInCollection           1
        baInterfaceNr( 0)       2
      AudioControl Interface Descriptor:
        bLength                12
        bDescriptorType        36
        bDescriptorSubtype      2 (INPUT_TERMINAL)
        bTerminalID             1
        wTerminalType      0x0201 Microphone
        bAssocTerminal          2
        bNrChannels             4
        wChannelConfig     0x0000
        iChannelNames           0 
        iTerminal               0 
      AudioControl Interface Descriptor:
        bLength                 9
        bDescriptorType        36
        bDescriptorSubtype      3 (OUTPUT_TERMINAL)
        bTerminalID             2
        wTerminalType      0x0101 USB Streaming
        bAssocTerminal          1
        bSourceID               3
        iTerminal               0 
      AudioControl Interface Descriptor:
        bLength                12
        bDescriptorType        36
        bDescriptorSubtype      6 (FEATURE_UNIT)
        bUnitID                 3
        bSourceID               1
        bControlSize            1
        bmaControls( 0)      0x00
        bmaControls( 1)      0x02
          Volume
        bmaControls( 2)      0x02
          Volume
        bmaControls( 3)      0x02
          Volume
        bmaControls( 4)      0x02
          Volume
        iFeature                0 
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        2
      bAlternateSetting       0
      bNumEndpoints           0
      bInterfaceClass         1 Audio
      bInterfaceSubClass      2 Streaming
      bInterfaceProtocol      0 
      iInterface              0 
    Interface Descriptor:
      bLength                 9
      bDescriptorType         4
      bInterfaceNumber        2
      bAlternateSetting       1
      bNumEndpoints           1
      bInterfaceClass         1 Audio
      bInterfaceSubClass      2 Streaming
      bInterfaceProtocol      0 
      iInterface              0 
      AudioStreaming Interface Descriptor:
        bLength                 7
        bDescriptorType        36
        bDescriptorSubtype      1 (AS_GENERAL)
        bTerminalLink           2
        bDelay                  1 frames
        wFormatTag              1 PCM
      AudioStreaming Interface Descriptor:
        bLength                11
        bDescriptorType        36
        bDescriptorSubtype      2 (FORMAT_TYPE)
        bFormatType             1 (FORMAT_TYPE_I)
        bNrChannels             4
        bSubframeSize           2
        bBitResolution         16
        bSamFreqType            1 Discrete
        tSamFreq[ 0]        16000
      Endpoint Descriptor:
        bLength                 9
        bDescriptorType         5
        bEndpointAddress     0x84  EP 4 IN
        bmAttributes            5
          Transfer Type            Isochronous
          Synch Type               Asynchronous
          Usage Type               Data
        wMaxPacketSize     0x0300  1x 768 bytes
        bInterval               4
        bRefresh                0
        bSynchAddress           0
        AudioControl Endpoint Descriptor:
          bLength                 7
          bDescriptorType        37
          bDescriptorSubtype      1 (EP_GENERAL)
          bmAttributes         0x01
            Sampling Frequency
          bLockDelayUnits         0 Undefined
          wLockDelay              0 Undefined
Device Qualifier (for other device speed):
  bLength                10
  bDescriptorType         6
  bcdUSB               2.00
  bDeviceClass            0 (Defined at Interface level)
  bDeviceSubClass         0 
  bDeviceProtocol         0 
  bMaxPacketSize0        64
  bNumConfigurations      1
Device Status:     0x0000
  (Bus Powered)

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: gspca, audio and ov534: regression.

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

On Wed, 6 Oct 2010 16:04:41 +0200
Antonio Ospite <ospite@studenti.unina.it> wrote:

> On Wed, 6 Oct 2010 13:48:55 +0200
> Jean-Francois Moine <moinejf@free.fr> wrote:
> 
> > On Wed, 6 Oct 2010 12:33:21 +0200
> > Antonio Ospite <ospite@studenti.unina.it> wrote:
> > 
> > > with 2.6.36-rc6 I can't use the ov534 gspca subdriver (with PS3 eye)
> > > anymore, when I try to capture video in dmesg I get:
> > > gspca: no transfer endpoint found
> > > 
> > > If I revert commit 35680ba I can make video capture work again but I
> > > still don't get the audio device in pulseaudio, it shows up in
> > > alsamixer but if I try to select it, on the console I get:
> > > cannot load mixer controls: Invalid argument
> > > 
[...]
> > About audio stream, I do not see how it can have been broken.
> >
> 
> PS3 Eye audio is working with linux-2.6.33.7 it is broken in
> linux-2.6.35.7 already, I'll try to further narrow down the interval.
> Ah, alsamixer doesn't work even when the device is OK in pulseaudio...
> 

I was wrong, the audio part works even in 2.6.36-rc6 but _only_ when
the webcam is plugged in from boot, could this have to do with the order
gspca and snd-usb-audio are loaded?

Regards,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: gspca, audio and ov534: regression.

[Jean-Francois Moine]

On Wed, 6 Oct 2010 16:04:41 +0200
Antonio Ospite <ospite@studenti.unina.it> wrote:

> Thanks, the following change fixes it, was this what you had in mind?
> 
> diff --git a/drivers/media/video/gspca/gspca.c
> b/drivers/media/video/gspca/gspca.c index b984610..30e0b32 100644
> --- a/drivers/media/video/gspca/gspca.c
> +++ b/drivers/media/video/gspca/gspca.c
> @@ -651,7 +651,7 @@ static struct usb_host_endpoint *get_ep(struct
> gspca_dev *gspca_dev) : USB_ENDPOINT_XFER_ISOC;
>         i = gspca_dev->alt;                     /* previous alt
> setting */ if (gspca_dev->cam.reverse_alts) {
> -               if (gspca_dev->audio)
> +               if (gspca_dev->audio && !gspca_dev->cam.bulk)
>                         i++;
>                 while (++i < gspca_dev->nbalt) {
>                         ep = alt_xfer(&intf->altsetting[i], xfer);
> @@ -659,7 +659,7 @@ static struct usb_host_endpoint *get_ep(struct
> gspca_dev *gspca_dev) break;
>                 }
>         } else {
> -               if (gspca_dev->audio)
> +               if (gspca_dev->audio && !gspca_dev->cam.bulk)
>                         i--;
>                 while (--i >= 0) {
>                         ep = alt_xfer(&intf->altsetting[i], xfer);

Yes, but, after thought, as there is only one alternate setting, the
tests could be:
	if (gspca_dev->audio && i < gspca_dev->nbalt - 1)
and
	if (gspca_dev->audio && i > 0)

This should work also for isochronous transfers.

regards.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

Re: gspca, audio and ov534: regression.

[Jean-Francois Moine]

On Wed, 6 Oct 2010 16:53:37 +0200
Antonio Ospite <ospite@studenti.unina.it> wrote:

> > PS3 Eye audio is working with linux-2.6.33.7 it is broken in
> > linux-2.6.35.7 already, I'll try to further narrow down the
> > interval. Ah, alsamixer doesn't work even when the device is OK in
> > pulseaudio... 
> 
> I was wrong, the audio part works even in 2.6.36-rc6 but _only_ when
> the webcam is plugged in from boot, could this have to do with the
> order gspca and snd-usb-audio are loaded?

Hi Antonio,

If you still have a kernel 2.6.33, may you try my test version (tarball
in my web page)? As it contain only the gspca stuff, this may tell if
the problem is in gspca or elsewhere in the kernel.

Best regards.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

Re: gspca, audio and ov534: regression.

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1307 bytes --]

On Thu, 7 Oct 2010 19:44:01 +0200
Jean-Francois Moine <moinejf@free.fr> wrote:

> On Wed, 6 Oct 2010 16:53:37 +0200
> Antonio Ospite <ospite@studenti.unina.it> wrote:
> 
> > > PS3 Eye audio is working with linux-2.6.33.7 it is broken in
> > > linux-2.6.35.7 already, I'll try to further narrow down the
> > > interval. Ah, alsamixer doesn't work even when the device is OK in
> > > pulseaudio... 
> > 
> > I was wrong, the audio part works even in 2.6.36-rc6 but _only_ when
> > the webcam is plugged in from boot, could this have to do with the
> > order gspca and snd-usb-audio are loaded?
> 
> Hi Antonio,
> 
> If you still have a kernel 2.6.33, may you try my test version (tarball
> in my web page)? As it contain only the gspca stuff, this may tell if
> the problem is in gspca or elsewhere in the kernel.
> 

JF I suspect the device not showing up in pulseaudio has nothing to do
with gspca at all. I can actually record audio using alsa even if
pulseaudio does not see the device, so it must be a pulseaudio issue.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: gspca, audio and ov534: regression.

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 1175 bytes --]

On Wed, 6 Oct 2010 20:35:53 +0200
Jean-Francois Moine <moinejf@free.fr> wrote:

> On Wed, 6 Oct 2010 16:04:41 +0200
> Antonio Ospite <ospite@studenti.unina.it> wrote:
> 
> > Thanks, the following change fixes it, was this what you had in mind?
> > 
> > diff --git a/drivers/media/video/gspca/gspca.c
[...]
> 
> Yes, but, after thought, as there is only one alternate setting, the
> tests could be:
> 	if (gspca_dev->audio && i < gspca_dev->nbalt - 1)
> and
> 	if (gspca_dev->audio && i > 0)
> 
> This should work also for isochronous transfers.

JF this change as is does not work for me, if I change the second check
to 
	if (gspca_dev->audio && i > 1)

it does, but I don't know if this breaks anything else.

In my case I have:

get_ep: gspca_dev->cam.reverse_alts: 0
get_ep: gspca_dev->alt: 1
get_ep: gspca_dev->nbalt: 1
get_ep: gspca_dev->audio: 1
get_ep: gspca_dev->cam.bulk: 1

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

Re: gspca, audio and ov534: regression.

[Jean-Francois Moine]

On Sun, 10 Oct 2010 12:02:50 +0200
Antonio Ospite <ospite@studenti.unina.it> wrote:

> JF this change as is does not work for me, if I change the second
> check to 
> 	if (gspca_dev->audio && i > 1)
> 
> it does, but I don't know if this breaks anything else.

Hi Antonio,

You are right, this is the way the test must be.

I'll try to have this in the kernel 2.6.36.

Regards.

-- 
Ken ar c'hentañ	|	      ** Breizh ha Linux atav! **
Jef		|		http://moinejf.free.fr/

Re: gspca, audio and ov534: regression.

[Antonio Ospite]

[-- Attachment #1: Type: text/plain, Size: 901 bytes --]

On Sun, 10 Oct 2010 12:21:29 +0200
Jean-Francois Moine <moinejf@free.fr> wrote:

> On Sun, 10 Oct 2010 12:02:50 +0200
> Antonio Ospite <ospite@studenti.unina.it> wrote:
> 
> > JF this change as is does not work for me, if I change the second
> > check to 
> > 	if (gspca_dev->audio && i > 1)
> > 
> > it does, but I don't know if this breaks anything else.
> 
> Hi Antonio,
> 
> You are right, this is the way the test must be.
> 
> I'll try to have this in the kernel 2.6.36.
> 

Thanks, feel free to add 

Reported-by: Antonio Ospite <ospite@studenti.unina.it>

or Tested-by or whatever-by you consider appropriate.

Regards,
  Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]