From: "David Härdeman" <david@hardeman.nu>
To: Jarod Wilson <jarod@redhat.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 2/3] mceusb: fix up reporting of trailing space
Date: Fri, 29 Oct 2010 21:21:21 +0200 [thread overview]
Message-ID: <20101029192121.GB12136@hardeman.nu> (raw)
In-Reply-To: <20101029030810.GC17238@redhat.com>
On Thu, Oct 28, 2010 at 11:08:10PM -0400, Jarod Wilson wrote:
> We were storing a bunch of spaces at the end of each signal, rather than
> a single long space. The in-kernel decoders were actually okay with
> this, but lirc isn't. Both are happy again with this change, which
> starts accumulating data upon seeing an 0x7f space, and then stores it
> when we see the next non-space, non-0x7f space, or an 0x80 end of signal
> command. To get to that final 0x80 properly, we also need to support
> proper parsing of 0x9f 0x01 commands, support for which is also added.
I think the driver could be further simplified by using
ir_raw_event_store_with_filter(), right?
--
David Härdeman
next prev parent reply other threads:[~2010-10-29 19:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-10-29 3:05 [PATCH 0/3] mceusb cleanups and new device support Jarod Wilson
2010-10-29 3:07 ` [PATCH 1/3] mceusb: add support for Conexant Hybrid TV RDU253S Jarod Wilson
2010-10-29 3:08 ` [PATCH 2/3] mceusb: fix up reporting of trailing space Jarod Wilson
2010-10-29 19:21 ` David Härdeman [this message]
2010-10-29 19:36 ` Jarod Wilson
2010-11-02 21:12 ` Jarod Wilson
2010-11-03 12:15 ` David Härdeman
2010-11-03 19:48 ` Jarod Wilson
2010-10-29 3:08 ` [PATCH 3/3] mceusb: buffer parsing fixups for 1st-gen device Jarod Wilson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101029192121.GB12136@hardeman.nu \
--to=david@hardeman.nu \
--cc=jarod@redhat.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).