From: "David Härdeman" <david@hardeman.nu>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH 1/2] [media] ir-kbd-i2c: add rc_dev as a parameter to the driver
Date: Fri, 12 Nov 2010 22:04:30 +0100 [thread overview]
Message-ID: <20101112210430.GA18719@hardeman.nu> (raw)
In-Reply-To: <20101112112838.2218e2d7@pedra>
On Fri, Nov 12, 2010 at 11:28:38AM -0200, Mauro Carvalho Chehab wrote:
>There are several fields on rc_dev that drivers can benefit. Allow drivers
>to pass it as a parameter to the driver.
>
>For now, the rc_dev parameter is optional. If drivers don't pass it, create
>them internally. However, the best is to create rc_dev inside the drivers,
>in order to fill other fields, like open(), close(), driver_name, etc.
>So, a latter patch making it mandatory and changing the caller drivers is
>welcome.
Looks good, no objections. Sorry for misinterpreting your suggested
change.
--
David Härdeman
prev parent reply other threads:[~2010-11-12 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1289568397.git.mchehab@redhat.com>
2010-11-12 13:28 ` [PATCH 2/2] [media] cx231xx: Fix i2c support at cx231xx-input Mauro Carvalho Chehab
2010-11-12 13:28 ` [PATCH 1/2] [media] ir-kbd-i2c: add rc_dev as a parameter to the driver Mauro Carvalho Chehab
2010-11-12 21:04 ` David Härdeman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20101112210430.GA18719@hardeman.nu \
--to=david@hardeman.nu \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox