From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-ey0-f171.google.com ([209.85.215.171]:54177 "EHLO mail-ey0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752650Ab0LOGqh (ORCPT ); Wed, 15 Dec 2010 01:46:37 -0500 Received: by eyg5 with SMTP id 5so951911eyg.2 for ; Tue, 14 Dec 2010 22:46:36 -0800 (PST) Date: Wed, 15 Dec 2010 16:46:34 +0900 From: Dmitri Belimov To: Stefan Ringel Cc: Mauro Carvalho Chehab , Felipe Sanches , Bee Hock Goh , Luis Henrique Fagundes , Linux Media Mailing List Subject: Re: tm6000 and IR Message-ID: <20101215164634.44846128@glory.local> In-Reply-To: <4D079ADF.2000705@arcor.de> References: <4CAD5A78.3070803@redhat.com> <20101008150301.2e3ceaff@glory.local> <4CAF0602.6050002@redhat.com> <20101012142856.2b4ee637@glory.local> <4CB492D4.1000609@arcor.de> <20101129174412.08f2001c@glory.local> <4CF51C9E.6040600@arcor.de> <20101201144704.43b58f2c@glory.local> <4CF67AB9.6020006@arcor.de> <20101202134128.615bbfa0@glory.local> <4CF71CF6.7080603@redhat.com> <20101206010934.55d07569@glory.local> <4CFBF62D.7010301@arcor.de> <20101206190230.2259d7ab@glory.local> <4CFEA3D2.4050309@arcor.de> <20101208125539.739e2ed2@glory.local> <4CFFAD1E.7040004@arcor.de> <20101214122325.5cdea67e@glory.local> <4D079ADF.2000705@arcor.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit List-ID: Sender: Mauro Carvalho Chehab Hi Stefan > Am 14.12.2010 04:23, schrieb Dmitri Belimov: > > Hi > > > > What about my last patch?? This is OK or bad? > > Our customers kick me every day with IR remotes. > > > > With my best regards, Dmitry. > I think, you use the second variant, Dmitry. > Why you doesn't use this key map - RCMAP_BEHOLD. No this remotes is different. RCMAP_BEHOLD has more buttons and some other scancodes. People from linux community who was made this keymap and function for reading data from IR decoder has error with scancode. Our true address of scancode is 0x86 0x6B They wrote 0x6B 0x86 Need fix some code of the saa7134-input and RCMAP_BEHOLD keytable. RCMAP_BEHOLD_WANDER same as RCMAP_BEHOLD_COLUMBUS but from IR decoder the saa7134 received only one byte of scancode. Need rework saa7134-input too for get address and restore full scancodes for extended NEC full scancodes. I'll make it after some time. > The power led we can change to a separate function, right. Ok > The nec initiation looks right and must adding code for tm5600/6000 (going > over message pipe). I haven't USB stick with tm5600/6000 for test. Need people with this TV cards. > rc5 need some code for tm6010 (for tm5600/6000 are the hack). I didn't touch this code because I haven't RC5 remotes and tm5600/6000 > And the logic for your remote control is unused for > the second variant, but ir->rc_type = rc_type are o.k.. I think your mean is wrong. Our IR remotes send extended NEC it is 4 bytes. We removed inverted 4 byte and now we have 3 bytes from remotes. I think we must have full RCMAP with this 3 bytes from remotes. And use this remotes with some different IR recievers like some TV cards and LIRC-hardware and other. No need different RCMAP for the same remotes to different IR recievers like now. If we use second variant I can't use RCMAP_BEHOLD because it has full 3 bytes scancodes. As you wrote. > Then the function call usb_set_interface in tm6000_video, can write > for example: > > stop_ir_pipe > usb_set_interface > start_ir_pipe Ok, I'll try. > I will adding vbi_buffer and device in the next, and isoc calculating > without video_buffer size. I try add radio. With my best regards, Dmitry.