Re: [PATCH] tm6000: add/rework reg.defines

Stefan Ringel
2011-01-20T19:27:13Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 20.01.2011 07:05, schrieb Dmitri Belimov:
> Hi
>
> Rework registers defines. Add TM6000 specific registers defines.
> Add marks and comments for TM6010 specific registers.
>
> diff --git a/drivers/staging/tm6000/tm6000-regs.h
b/drivers/staging/tm6000/tm6000-regs.h
> index 1f0ced8..5375a83 100644
> --- a/drivers/staging/tm6000/tm6000-regs.h
> +++ b/drivers/staging/tm6000/tm6000-regs.h
> @@ -97,6 +97,34 @@ enum {
> TM6000_URB_MSG_ERR,
> };
>
> +/* Define specific TM6000 Video decoder registers */
> +#define TM6000_REQ07_RD8_TEST_SEL 0x07, 0xd8
> +#define TM6000_REQ07_RD9_A_SIM_SEL 0x07, 0xd9
> +#define TM6000_REQ07_RDA_CLK_SEL 0x07, 0xda
> +#define TM6000_REQ07_RDB_OUT_SEL 0x07, 0xdb
> +#define TM6000_REQ07_RDC_NSEL_I2S 0x07, 0xdc
> +#define TM6000_REQ07_RDD_GPIO2_MDRV 0x07, 0xdd
> +#define TM6000_REQ07_RDE_GPIO1_MDRV 0x07, 0xde
> +#define TM6000_REQ07_RDF_PWDOWN_ACLK 0x07, 0xdf
> +#define TM6000_REQ07_RE0_VADC_REF_CTL 0x07, 0xe0
> +#define TM6000_REQ07_RE1_VADC_DACLIMP 0x07, 0xe1
> +#define TM6000_REQ07_RE2_VADC_STATUS_CTL 0x07, 0xe2
> +#define TM6000_REQ07_RE3_VADC_INP_LPF_SEL1 0x07, 0xe3
> +#define TM6000_REQ07_RE4_VADC_TARGET1 0x07, 0xe4
> +#define TM6000_REQ07_RE5_VADC_INP_LPF_SEL2 0x07, 0xe5
> +#define TM6000_REQ07_RE6_VADC_TARGET2 0x07, 0xe6
> +#define TM6000_REQ07_RE7_VADC_AGAIN_CTL 0x07, 0xe7
> +#define TM6000_REQ07_RE8_VADC_PWDOWN_CTL 0x07, 0xe8
> +#define TM6000_REQ07_RE9_VADC_INPUT_CTL1 0x07, 0xe9
> +#define TM6000_REQ07_REA_VADC_INPUT_CTL2 0x07, 0xea
> +#define TM6000_REQ07_REB_VADC_AADC_MODE 0x07, 0xeb
> +#define TM6000_REQ07_REC_VADC_AADC_LVOL 0x07, 0xec
> +#define TM6000_REQ07_RED_VADC_AADC_RVOL 0x07, 0xed
> +#define TM6000_REQ07_REE_VADC_CTRL_SEL_CONTROL 0x07, 0xee
> +#define TM6000_REQ07_REF_VADC_GAIN_MAP_CTL 0x07, 0xef
> +#define TM6000_REQ07_RFD_BIST_ERR_VST_LOW 0x07, 0xfd
> +#define TM6000_REQ07_RFE_BIST_ERR_VST_HIGH 0x07, 0xfe
> +
> /* Define TM6000/TM6010 Video decoder registers */
> #define TM6010_REQ07_R00_VIDEO_CONTROL0 0x07, 0x00
> #define TM6010_REQ07_R01_VIDEO_CONTROL1 0x07, 0x01
> @@ -241,6 +269,7 @@ enum {
> #define TM6010_REQ07_RC9_VEND1 0x07, 0xc9
> #define TM6010_REQ07_RCA_VEND0 0x07, 0xca
> #define TM6010_REQ07_RCB_DELAY 0x07, 0xcb
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RCC_ACTIVE_VIDEO_IF 0x07, 0xcc
> #define TM6010_REQ07_RD0_USB_PERIPHERY_CONTROL 0x07, 0xd0
> #define TM6010_REQ07_RD1_ADDR_FOR_REQ1 0x07, 0xd1
> @@ -250,32 +279,59 @@ enum {
> #define TM6010_REQ07_RD5_POWERSAVE 0x07, 0xd5
> #define TM6010_REQ07_RD6_ENDP_REQ1_REQ2 0x07, 0xd6
> #define TM6010_REQ07_RD7_ENDP_REQ3_REQ4 0x07, 0xd7
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RD8_IR 0x07, 0xd8
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RD8_IR_BSIZE 0x07, 0xd9
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RD8_IR_WAKEUP_SEL 0x07, 0xda
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RD8_IR_WAKEUP_ADD 0x07, 0xdb
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RD8_IR_LEADER1 0x07, 0xdc
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RD8_IR_LEADER0 0x07, 0xdd
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RD8_IR_PULSE_CNT1 0x07, 0xde
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RD8_IR_PULSE_CNT0 0x07, 0xdf
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RE0_DVIDEO_SOURCE 0x07, 0xe0
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RE0_DVIDEO_SOURCE_IF 0x07, 0xe1
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RE2_OUT_SEL2 0x07, 0xe2
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RE3_OUT_SEL1 0x07, 0xe3
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RE4_OUT_SEL0 0x07, 0xe4
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RE5_REMOTE_WAKEUP 0x07, 0xe5
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RE7_PUB_GPIO 0x07, 0xe7
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RE8_TYPESEL_MOS_I2S 0x07, 0xe8
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RE9_TYPESEL_MOS_TS 0x07, 0xe9
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_REA_TYPESEL_MOS_CCIR 0x07, 0xea
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RF0_BIST_CRC_RESULT0 0x07, 0xf0
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RF1_BIST_CRC_RESULT1 0x07, 0xf1
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RF2_BIST_CRC_RESULT2 0x07, 0xf2
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RF3_BIST_CRC_RESULT3 0x07, 0xf3
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RF4_BIST_ERR_VST2 0x07, 0xf4
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RF5_BIST_ERR_VST1 0x07, 0xf5
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RF6_BIST_ERR_VST0 0x07, 0xf6
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RF7_BIST 0x07, 0xf7
> +/* ONLY for TM6010 */
> #define TM6010_REQ07_RFE_POWER_DOWN 0x07, 0xfe
> #define TM6010_REQ07_RFF_SOFT_RESET 0x07, 0xff
>
> @@ -477,7 +533,8 @@ enum {
> #define TM6010_REQ05_RC4_DATA_FIFO14 0x05, 0xf8
> #define TM6010_REQ05_RC4_DATA_FIFO15 0x05, 0xfc
>
> -/* Define TM6000/TM6010 Audio decoder registers */
> +/* Define TM6010 Audio decoder registers */
> +/* This core available only in TM6010 */
> #define TM6010_REQ08_R00_A_VERSION 0x08, 0x00
> #define TM6010_REQ08_R01_A_INIT 0x08, 0x01
> #define TM6010_REQ08_R02_A_FIX_GAIN_CTRL 0x08, 0x02
> @@ -518,7 +575,7 @@ enum {
> #define TM6010_REQ08_R27_A_NOISE_AMP 0x08, 0x27
> #define TM6010_REQ08_R28_A_AUDIO_MODE_RES 0x08, 0x28
>
> -/* Define TM6000/TM6010 Video ADC registers */
> +/* Define TM6010 Video ADC registers */
> #define TM6010_REQ08_RE0_ADC_REF 0x08, 0xe0
> #define TM6010_REQ08_RE1_DAC_CLMP 0x08, 0xe1
> #define TM6010_REQ08_RE2_POWER_DOWN_CTRL1 0x08, 0xe2
> @@ -534,7 +591,7 @@ enum {
> #define TM6010_REQ08_REC_REVERSE_YC_CTRL 0x08, 0xec
> #define TM6010_REQ08_RED_GAIN_SEL 0x08, 0xed
>
> -/* Define TM6000/TM6010 Audio ADC registers */
> +/* Define TM6010 Audio ADC registers */
> #define TM6010_REQ08_RF0_DAUDIO_INPUT_CONFIG 0x08, 0xf0
> #define TM6010_REQ08_RF1_AADC_POWER_DOWN 0x08, 0xf1
> #define TM6010_REQ08_RF2_LEFT_CHANNEL_VOL 0x08, 0xf2
>
> Signed-off-by: Beholder Intl. Ltd. Dmitry Belimov <d.belimov@gmail.com>
>
>
> With my best regards, Dmitry.
Dmitry, that are good news! And that anwers my questions. Now I think
we must separate the both chipsets in any points:

* audio standards
* video standards
* in tm6000-alsa the functions " _tm6000_start_audio_dma" and
"_tm6000_stop_audio_dma"
* in tm6000-input "tm6000_ir_config"
* in tm6000-core ?? "init_analog_mode" and "init_digital_mode"
* in tm6000-core "tm6000_set_audio_bitrate"

My rework in tm6000-video, isoc usb buffer and vbi device, I move this
into summer 2011!!

Stefan Ringel
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.12 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/

iQEcBAEBAgAGBQJNOIxEAAoJEAWtPFjxMvFG3LQIAKlIMVWYTTPA5RD45Sw4QBQH
I+yqhs89Qe7bKl+JjDrSiCG/ttRDtTy0+ksUFmicglntLmmtPVQnv59tIU9evQmn
Yt7n1XWHcq442+ySbQ/3fVLay1WG1eJ3UEsC7bkpT2hSUhmUf6zjSZ3ockIJfxEJ
geqFOy630vfwcKcS7KWgAJO8LKYQXcW8TLmkb3/D4W1G8o7zCKIH624Q5u+k1IGk
mmm5CiqO17FS/oK0pxTZAY8uqWr3DH3UUqiMR3GdGoivaOR+1QCdrrYZXkQxklai
zPQ6AYx/zPStZK8iUSSOHpVkfqHTgB3f6BSpsWhNGT3mgW8tTxnAz/MyECUiEms=
=Cxjk
-----END PGP SIGNATURE-----