From: Oliver Endriss <o.endriss@gmx.de>
To: Dan Carpenter <error27@gmail.com>
Cc: Andreas Oberritter <obi@linuxtv.org>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] [media] av7110: check for negative array offset
Date: Fri, 7 Jan 2011 20:01:19 +0100 [thread overview]
Message-ID: <201101072001.20850@orion.escape-edv.de> (raw)
In-Reply-To: <20110107134651.GH1717@bicker>
Hi,
On Friday 07 January 2011 14:46:51 Dan Carpenter wrote:
> info->num comes from the user. It's type int. If the user passes
> in a negative value that would cause memory corruption.
>
> Signed-off-by: Dan Carpenter <error27@gmail.com>
> ---
> V2: change the check instead of making num and unsigned int
>
> diff --git a/drivers/media/dvb/ttpci/av7110_ca.c b/drivers/media/dvb/ttpci/av7110_ca.c
> index 122c728..923a8e2 100644
> --- a/drivers/media/dvb/ttpci/av7110_ca.c
> +++ b/drivers/media/dvb/ttpci/av7110_ca.c
> @@ -277,7 +277,7 @@ static int dvb_ca_ioctl(struct file *file, unsigned int cmd, void *parg)
> {
> ca_slot_info_t *info=(ca_slot_info_t *)parg;
>
> - if (info->num > 1)
> + if ((unsigned)info->num > 1)
> return -EINVAL;
> av7110->ci_slot[info->num].num = info->num;
> av7110->ci_slot[info->num].type = FW_CI_LL_SUPPORT(av7110->arm_app) ?
> --
> To unsubscribe from this list: send the line "unsubscribe linux-media" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
Imho casts are a last resort and should be avoided, if there is a better
way to do it. The obvious fix is
if (info->num < 0 || info->num > 1)
return -EINVAL;
CU
Oliver
--
----------------------------------------------------------------
VDR Remote Plugin 0.4.0: http://www.escape-edv.de/endriss/vdr/
4 MByte Mod: http://www.escape-edv.de/endriss/dvb-mem-mod/
Full-TS Mod: http://www.escape-edv.de/endriss/dvb-full-ts-mod/
----------------------------------------------------------------
next prev parent reply other threads:[~2011-01-07 19:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-06 19:41 [patch] [media] av7110: make array offset unsigned Dan Carpenter
2011-01-07 12:44 ` Andreas Oberritter
2011-01-07 13:46 ` [patch v2] [media] av7110: check for negative array offset Dan Carpenter
2011-01-07 19:01 ` Oliver Endriss [this message]
2011-01-07 19:41 ` [patch v3] " Dan Carpenter
2011-01-07 13:51 ` [patch] [media] av7110: make array offset unsigned Dan Carpenter
2011-01-07 14:02 ` Vasiliy Kulikov
2011-01-07 14:05 ` Andreas Oberritter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201101072001.20850@orion.escape-edv.de \
--to=o.endriss@gmx.de \
--cc=error27@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=obi@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox