From: Jean-Francois Moine <moinejf@free.fr>
To: Antonio Ospite <ospite@studenti.unina.it>
Cc: linux-media@vger.kernel.org
Subject: Re: [GIT PATCHES FOR 2.6.38] gspca for_2.6.38
Date: Thu, 13 Jan 2011 17:30:21 +0100 [thread overview]
Message-ID: <20110113173021.1f8a7b8b@tele> (raw)
In-Reply-To: <20110113123804.d391b10e.ospite@studenti.unina.it>
On Thu, 13 Jan 2011 12:38:04 +0100
Antonio Ospite <ospite@studenti.unina.it> wrote:
> > Jean-François Moine (9):
> [...]
> > gspca - ov534: Use the new video control mechanism
>
> In this commit, is there a reason why you didn't rename also
> sd_setagc() into setagc() like for the other functions?
>
> I am going to test the changes and report back if there's anything
> more, I like the cleanup tho.
Hi Antonio,
With the new video control mechanism, the '.set_control' function is
called only when capture is active. Otherwise, the '.set' function is
called in any case, and here, it activates/inactivates the auto white
balance control... Oh, I forgot to disable the awb when the agc is
disabled!
Thank you for reporting any problem. BTW, the webcam 06f8:3002 which
had been removed some time ago is being tested. I will add it to this
subdriver as soon as it works correctly.
Cheers.
--
Ken ar c'hentañ | ** Breizh ha Linux atav! **
Jef | http://moinejf.free.fr/
next prev parent reply other threads:[~2011-01-13 16:27 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-13 10:59 [GIT PATCHES FOR 2.6.38] gspca for_2.6.38 Jean-Francois Moine
2011-01-13 11:38 ` Antonio Ospite
2011-01-13 16:30 ` Jean-Francois Moine [this message]
2011-01-14 15:05 ` Antonio Ospite
2011-01-16 16:38 ` Mauro Carvalho Chehab
-- strict thread matches above, loose matches on Subject: below --
2010-12-28 10:42 Jean-Francois Moine
2010-12-25 17:11 Jean-Francois Moine
2010-11-13 9:46 Jean-Francois Moine
2010-11-13 12:16 ` Anca Emanuel
2010-11-13 14:18 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110113173021.1f8a7b8b@tele \
--to=moinejf@free.fr \
--cc=linux-media@vger.kernel.org \
--cc=ospite@studenti.unina.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox