From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>, linux-media@vger.kernel.org
Subject: [PATCH incremental update] firedtv: fix remote control - addendum
Date: Mon, 17 Jan 2011 21:07:56 +0100 [thread overview]
Message-ID: <20110117210756.510d4135@stein> (raw)
In-Reply-To: <20110117170015.GA15404@core.coreip.homeip.net>
Dimitry notes that EV_SYN is also necessary between down and up,
otherwise userspace could combine their state.
Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
---
Hi Mauro,
since you already pushed out the first version of "firedtv: fix remote
control with newer Xorg evdev", here is the differential patch to the
updated version. It's surely not super urgent though.
drivers/media/dvb/firewire/firedtv-rc.c | 1 +
1 file changed, 1 insertion(+)
Index: b/drivers/media/dvb/firewire/firedtv-rc.c
===================================================================
--- a/drivers/media/dvb/firewire/firedtv-rc.c
+++ b/drivers/media/dvb/firewire/firedtv-rc.c
@@ -190,6 +190,7 @@ void fdtv_handle_rc(struct firedtv *fdtv
}
input_report_key(idev, code, 1);
+ input_sync(idev);
input_report_key(idev, code, 0);
input_sync(idev);
}
--
Stefan Richter
-=====-==-== ---= =---=
http://arcgraph.de/sr/
prev parent reply other threads:[~2011-01-17 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-16 8:39 [PATCH] firedtv: fix remote control with newer Xorg evdev Stefan Richter
2011-01-17 8:17 ` Dmitry Torokhov
2011-01-17 13:17 ` [PATCH update] " Stefan Richter
2011-01-17 17:00 ` Dmitry Torokhov
2011-01-17 20:07 ` Stefan Richter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110117210756.510d4135@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox