* [patch 1/2] [media] dib9000: fix return type in dib9000_mbx_send_attr()
@ 2011-01-19 14:28 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2011-01-19 14:28 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Patrick Boettcher, Olivier Grenie, linux-media, kernel-janitors
dib9000_mbx_send_attr() returns an int. It doesn't work to save
negative error codes in an unsigned char, so I've made "ret" an int
type.
Signed-off-by: Dan Carpenter <error27@gmail.com>
diff --git a/drivers/media/dvb/frontends/dib9000.c b/drivers/media/dvb/frontends/dib9000.c
index 43fb6e4..9151876 100644
--- a/drivers/media/dvb/frontends/dib9000.c
+++ b/drivers/media/dvb/frontends/dib9000.c
@@ -486,10 +486,11 @@ static int dib9000_mbx_host_init(struct dib9000_state *state, u8 risc_id)
#define MAX_MAILBOX_TRY 100
static int dib9000_mbx_send_attr(struct dib9000_state *state, u8 id, u16 * data, u8 len, u16 attr)
{
- u8 ret = 0, *d, b[2];
+ u8 *d, b[2];
u16 tmp;
u16 size;
u32 i;
+ int ret = 0;
if (!state->platform.risc.fw_is_running)
return -EINVAL;
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2011-01-19 14:29 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-01-19 14:28 [patch 1/2] [media] dib9000: fix return type in dib9000_mbx_send_attr() Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox