From: Dan Carpenter <error27@gmail.com>
To: Julia Lawall <julia@diku.dk>
Cc: Peter Huewe <peterhuewe@gmx.de>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org,
Steven Toth <stoth@kernellabs.com>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH] video/saa7164: Fix sparse warning: Using plain integer as NULL pointer
Date: Wed, 26 Jan 2011 07:25:51 +0300 [thread overview]
Message-ID: <20110126042551.GK2721@bicker> (raw)
In-Reply-To: <Pine.LNX.4.64.1101252319570.3668@ask.diku.dk>
On Tue, Jan 25, 2011 at 11:20:44PM +0100, Julia Lawall wrote:
> On Tue, 25 Jan 2011, Peter Huewe wrote:
>
> > This patch fixes the warning "Using plain integer as NULL pointer",
> > generated by sparse, by replacing the offending 0s with NULL.
> I recall (a number of years ago) being told that for things like kmalloc,
> the proper test was !x, not x == NULL.
>
It was Al Viro who said that. Here's the link.
http://lwn.net/Articles/331593/
regards,
dan carpenter
prev parent reply other threads:[~2011-01-26 4:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-25 20:54 [PATCH] video/saa7164: Fix sparse warning: Using plain integer as NULL pointer Peter Huewe
2011-01-25 22:20 ` Julia Lawall
2011-01-25 22:54 ` Peter Hüwe
2011-01-25 23:05 ` Devin Heitmueller
2011-01-26 0:30 ` Andy Walls
2011-01-26 5:59 ` Julia Lawall
2011-01-26 9:29 ` Mauro Carvalho Chehab
2011-01-30 19:33 ` [PATCH v2] " Peter Huewe
2011-01-30 20:02 ` Devin Heitmueller
2011-01-26 4:25 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110126042551.GK2721@bicker \
--to=error27@gmail.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=peterhuewe@gmx.de \
--cc=stoth@kernellabs.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox